[GRASS5] PATCH: sql expression parser

Glynn Clements glynn at gclements.plus.com
Sat Jun 11 00:54:20 EDT 2005


Paul Kelly wrote:

> > Might including
> > the generated files (lex.yy.c and y.tab.c) in the "source" distribution be a
> > solution?
> 
> That sounds like quite a good idea... I've noticed in some free software 
> projects they don't even include the generated configure script in CVS and 
> the user has to generate it themselves with autoconf. In GRASS the 
> developers always generate the configure script; maybe "pre-generating" 
> the lex and yacc files and storing in CVS would be a worthwhile idea.

That's a bad idea, IMHO.

Either developers will forget to commit them when lex.l or yac.y
change, or they will end up being committed when lex.l or yac.y
haven't changed (due to different lex/yacc programs generating subtly
different code). Also, CVS doesn't deal with timestamps correctly, so
there can be version skew issues.

It would be better to just ensure that all lex/yacc files can be
processed by any version of these tools. It shouldn't be that hard; we
aren't doing anything particularly complex with lex/yacc.

It isn't an issue for the configure script because this isn't
re-generated automatically as part of the normal build process.

-- 
Glynn Clements <glynn at gclements.plus.com>




More information about the grass-dev mailing list