[GRASS-dev] NVIZ now broken?

[Michael Barton]

Thanks Markus. I'm taking this to also indicate that you have no problem
with ComboBox and its labels in the vector panel.

The [G_msg "text..."] clause simply means to get the label from running the
G_msg  on some text. I think that the G_msg procedure is for helping with
internationalization. It should probably be implemented throughout NVIZ
(where it is not used at all).

It *should not* make any difference to the operation of ComboBox. If
anything, ComboBox statements using a [G_msg] clause are more likely to fail
simply because it's calling an external procedure.

That said, I'll commit a version of panel_site.tcl using [G_msg] to test
tomorrow if I can. Then we can see if this is a fix. If so, it's still a
bandaid, but at least one that is consistent with the rest of the GUI code.
My bets are on it not working.

As it is, ComboBox -label works on my Mac and on our FC4 system. It doesn't
work on your box or on at least one Windows system reported, but only in
NVIZ AFAIK.

Michael
__________________________________________
Michael Barton, Professor of Anthropology
School of Human Evolution & Social Change
Center for Social Dynamics & Complexity
Arizona State University

phone: 480-965-6213
fax: 480-965-7671
www: http://www.public.asu.edu/~cmbarton



> From: Markus Neteler <neteler at itc.it>
> Date: Sat, 18 Nov 2006 22:05:08 +0100
> To: <grass-dev at grass.itc.it>
> Subject: Re: [GRASS-dev] NVIZ now broken?
> 
> Michael,
> 
> as far as I see the ComboBox is used in a different way:
> 
> mapprint.tcl:    ComboBox $row.c -label "" -width 20  -textvariable
> psprint::paper_preset \
> vector.tcl:    ComboBox $row.b -label [G_msg "label part to align with vector
> point"] \
> vector.tcl:    ComboBox $row.c -label [G_msg " justification"] \
> 
> -> note G_msg in vector.tcl
> 
> while it was in NVIZ:
> set markertype [ComboBox $row1.marker -label "  marker type " -width 8 \
> 
> ?
> Markus
> 
> 
> On Sat, Nov 18, 2006 at 10:40:03AM -0700, Michael Barton wrote:
>> Paul,
>> 
>> Thanks much for the update. This  is easy to fix in nviz. The widget label
>> can be provided by a separate label widget instead of using the ComboBox
>> -label option. 
>> 
>> However, I'm much more concerned about the larger issue of the version of
>> bwidgets that GRASS depends on not working correctly. This same ComboBox
>> widget with -label option is used in a number of other places in the GUI
>> (such as the GIS Manager vector layer panel).
>> 
>> If it is failing in one place (nviz) it should be failing in all places if
>> this is a general problem. If it is only failing in nviz, there is some
>> other more fundamental problem that needs to be solved or I will have no
>> idea of what kinds of GUI options work and which do not.
>> 
>> I just tried the new nviz GUI updates on our FC4 system. I still have to
>> find out which version of TclTk it is running, but nviz works
>> fine--including the ComboBox with -label option. Given Paul's message, it
>> doesn't sound like it is limited to a particular version of TclTk or OS. So
>> something else is broken.
>> 
>> Michael
>> 
>> __________________________________________
>> Michael Barton, Professor of Anthropology
>> School of Human Evolution & Social Change
>> Center for Social Dynamics & Complexity
>> Arizona State University
>> 
>> phone: 480-965-6213
>> fax: 480-965-7671
>> www: http://www.public.asu.edu/~cmbarton
>> 
>> 
>> 
>>> From: Paul Kelly <paul-grass at stjohnspoint.co.uk>
>>> Date: Sat, 18 Nov 2006 16:43:27 +0000 (GMT)
>>> To: Hamish <hamish_nospam at yahoo.com>
>>> Cc: <michael.barton at asu.edu>, <neteler at itc.it>, <bcovill at tekmap.ns.ca>,
>>> <grass-dev at grass.itc.it>
>>> Subject: Re: [GRASS-dev] NVIZ now broken?
>>> 
>>> 
>>> 
>>> On Sun, 19 Nov 2006, Hamish wrote:
>>> 
>>>> Markus:
>>>>>>> The tcl error is:
>>>>>>> 
>>>>>>> Index: panel_site.tcl
>>>>>>> ===================================================================
>>>>>>> RCS file:
>>>>>> /grassrepository/grass6/visualization/nviz/scripts/panel_site.tcl,v >
>>>>>> retrieving revision 2.6 > diff -u -r2.6 panel_site.tcl
>>>>>>> --- panel_site.tcl      13 Nov 2006 16:33:33 -0000      2.6
>>>>>>> +++ panel_site.tcl      16 Nov 2006 17:05:59 -0000
>>>>>>> @@ -125,7 +125,7 @@
>>>>>>>                 -command "change_color site $row1.color"]
>>>>>>>      bind $ptcolor <Expose> "$row1.color configure -bg
>>>>>> \[get_curr_sv_color > site\]"
>>>>>>> 
>>>>>>> -    set markertype [ComboBox $row1.marker -label "  marker type "
>>>>>> -width 8 \ > +    set markertype [ComboBox $row1.marker  -width 8 \
>>>>>>>         -textvariable Nv_(siteshape) -modifycmd change_marker \
>>>>>>>         -values {"x" "sphere" "diamond" "cube" "box" "gyro" "aster"
>>>>>>> "histogram"}]
>>>>>>> 
>>>>>>> -label doesn't work here.
>>> [...]
>>>> dumb guess: what if you strip away the spaces in
>>>> 
>>>>  -label "  marker type "
>>>> to
>>>>  -label "marker type"
>>>> or
>>>>  -label "marker_type"
>>>> 
>>>> ?
>>> 
>>> Just tried that with various combinations of spaces and no spaces, with
>>> and without quotes. Nothing seems to work apart from deleting the -label
>>> parameter entirely...
>>> 
>>> Paul
>>> 
>> 
> 
> -- 
> Markus Neteler  <neteler itc it>  http://mpa.itc.it/markus/
> ITC-irst -  Centro per la Ricerca Scientifica e Tecnologica
> MPBA - Predictive Models for Biol. & Environ. Data Analysis
> Via Sommarive, 18        -       38050 Povo (Trento), Italy
> 
>