[GRASS-dev] r.mapcalc and g.remove --v/q issues

[Jachym Cepicky]

hallo,

On Mon, Oct 09, 2006 at 01:04:14AM +1300, Hamish wrote:
> -            verbose = MINLEVEL;
> +            verbose = MAXLEVEL;

I agree

> 
> ps -
> in verbose.c, is this test correct?
> 
> static int verbose;
> G_verbose() {
>  ..
>     /* verbose not defined -> get it from env. */
>     if ( !verbose ) {
>  ..
> }
> 
> so it gets read from GRASS_VERBOSE not only if its unset but also if
> it happens to be at MINLEVEL?
> 

no, sorry, this is not correct. as glyn writes, it should be initialized
to -1 and the test should look like 

    if ( verbose < 0 )

could you commit this changes, or should I?

thank you

jachym

-- 
Jachym Cepicky
e-mail: jachym.cepicky at centrum.cz
URL: http://les-ejk.cz
GPG: http://les-ejk.cz/gnupg_public_key/jachym_cepicky-gpg_public_key.asc
-----------------------------------------   
OFFICE:                                     
Department of Geoinformation Technologies 
Zemedelska 3
613 00, Brno
Czech Republick
e-mail: xcepicky at node.mendelu.cz
URL:    http://mapserver.mendelu.cz
Tel.:   +420 545 134 514
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: Digital signature
Url : http://lists.osgeo.org/pipermail/grass-dev/attachments/20061009/fa621126/attachment.bin