[GRASS-dev] v.bspline -> v.surf.bspline ?

[Hamish]

> v.bspline should be renamed to v.surf.bspline for the sake of
> consistency.

I haven't actually used the module, but in theory I agree it should be
renamed.


> >> Also, I believe it would be better to move it to 'vector/' instead
> >> of 'vector/lidar/' as it is not particularly specific to LIDAR.

it uses vector/lidar/lidarlib/, so you might have to move 
vector/lidar/lidarlib/ to lib/lidar/ as well. I think moving v.bspline
without moving lidarlib/ is a mistake.


> > I have written twice to the author(s) but didn't receive a
> > response on this issue.
> > It is now VERY urgent since we have already done 6.2.0.beta2.
> >
> > Or we decide to keep the name in 6.2 and change it in 6.3.
> >
> > Or we just change it without listening to the author(s).

note this is a port from GRASS 5. The according to the help page the
original authors are Maria Antonia Brovelli, Massimiliano Cannata,
Ulisse Longoni, and Mirko Reguzzoni. That module was
grass/src.contrib/POLIMICO/s.bspline.reg/


my thoughts:
* hopefully we get an "ok" from the authors soon.
* if not, the code is in our care & we do what we need to do.
* it is easy enough to change the name now, just:

Index: Makefile
===================================================================
RCS file:
/home/grass/grassrepository/grass6/vector/lidar/v.bspline/Makefile,v
retrieving revision 1.3
diff -u -r1.3 Makefile
--- Makefile    22 Aug 2006 20:03:35 -0000      1.3
+++ Makefile    4 Sep 2006 04:36:15 -0000
@@ -1,6 +1,6 @@
 MODULE_TOPDIR = ../../..
 
-PGM = v.bspline
+PGM = v.surf.bspline
 
 LIBES = $(LIDARLIB) $(VECTLIB) $(DBMILIB) $(GISLIB) $(MATHLIB) $(SEGMENTLIB) $(GMATHLIB)
 DEPENDENCIES= $(LIDARDEP) $(VECTDEP) $(DBMIDEP) $(GISDEP) $(BSPLINE_ARCH_OBJ) $(GMATHDEP) 


It is easy to change the name later: make v.bspline a symlink for 
backwards compatibility*, but much better to do now it before
release IMO.

[*] see d.paint.labels -> d.labels rename; CVS dir structure unchanged


lidarlib/PolimiFunct.h defines structs "Point" and "element". I suggest
these be changed to something less likely to collide with something else.
Also PolimiFunct.h re-#defines TRUE, FALSE, after #including gis.h.


> > However, moding code around in CVS isn't nice, so I don't
> > know if it must be really moved out of vector/lidar/.

This depends on what happens to lidarlib/ I think.
We do have raster/simwe/ and raster/wildfire/ without complaint.


my vote is to rename it in the Makefile now and consider reverting it
if the authors object. We can move it later in CVS if wanted without
affecting anything as far as the user.


btw, it's missing from the TclTk menu, so are the other v.lidar.*.


Hamish