[GRASS-dev] [grass-code I][455] r.proj segfaults after Jul 14 changes

[Hamish]

Paul Kelly wrote:
> Well apart from passing NULL instead of an empty string being obviously 
> wrong, a message that actually contains no information would appear to be 
> improper use by definition, no? What's the point of it?

It's valid for G_done_msg(), it outputs like:
$MODULE complete. $*

with "", it just says "$MOD complete. " So passing a message is optional extra.


However, G_message(""); for a blank line is ugly ugly, I'd suggest either
adding a new lib fn (lame solution) or removing whitespace stripping action
from G_message(), and allow '\n' back in the string. The problem with this is
that self-formatting gets abused, and perhaps confuses the line-wrap code?  
(this is just off the top of my head, I can't check what the code actually does
right now)


Hamish



       
____________________________________________________________________________________
Take the Internet to Go: Yahoo!Go puts the Internet in your pocket: mail, news, photos & more. 
http://mobile.yahoo.com/go?refer=1GNXIC