[GRASS-dev] [grass-code I][455] r.proj segfaults after Jul 14
changes
Glynn Clements
glynn at gclements.plus.com
Wed Aug 8 16:19:34 EDT 2007
Paul Kelly wrote:
> > Actually, it's more than just G_done_msg - there are a few G_message(NULL) in
> > there, and the r.proj source is really in r.proj.seg, the r.proj source
> > folder is deprecated.
> >
> > Not to mention the other modules I found null messages in, as I mentioned in
> > a followup to the bug report.
> >
> > If (NULL) is indeed improper use of the message functions, I could take care
>
> Well apart from passing NULL instead of an empty string being obviously
> wrong, a message that actually contains no information would appear to be
> improper use by definition, no? What's the point of it?
> Just seems like an obvious remark to make anyway...
The G_message(NULL) calls appear between the code which prints the
input and output regions. IOW, they're there to add blank lines.
Personally, I think that section should use G_verbose_message().
--
Glynn Clements <glynn at gclements.plus.com>
More information about the grass-dev
mailing list