[GRASS-dev] Modules

[Glynn Clements]

Maciej Sieczka wrote:

> >> The remaining step is to reinstate the bgcmd= option.
> 
> bgcmd works. Accepts multiple d.* commands sepearated with ";". Great.
> 
> > Done; updated patch (again, against CVS HEAD) attached.
> 
> Issues:
> 
> 1. Points/centroids/nodes - irregular shape, see the attached points.png.

I see. I'm passing exactly the same coordinates to the Tk canvas
widget that were being used with libraster, but it appears that Tk
interprets them slightly differently. However, I haven't been able to
determine the appropriate "tweak" to get the two to match.

Ultimately, we may be better off using bitmaps for icons, so I don't
want to spend too much time on this.

> 2. Digitize point tool is deselected after digitizing first point; to
> digitize another point, one has to select the tool again, and so on.
> Same applies to digitize centroid tool.

Does this do the right thing?

--- util.c~	2007-02-22 20:58:16.000000000 +0000
+++ util.c	2007-02-23 21:34:06.000000000 +0000
@@ -64,6 +64,7 @@
     tool_closure = NULL;
 
     driver_close();
+    next_tool();
 }
 
 void cancel_tool(void)

> 3. Setting a new line width and redrawing usually doesn't make any
> difference.

It works for me. Note that you have to press Return after editing the
value.

> 4. Region is now handled differently than it used to in v.digit.
> Previously, the backdrop maps AND the currently digitized map where
> displayed trimmed to zoom box shape (region_former.png). After your
> patch, only the backdrop is, while the map being digitized is not
> (region_patched.png). IMO a solution is to either revert the previous
> behaviour, or, preferably, make v.digit ignore the region extent, and
> let it fill the window at maximum (I think this is preffered in case of
> v.digit - when one is digitising, he wants to see the maximum of it).

I can do either; the previous behaviour (honour the user's region
settings, and clip the vector to it) is the easier solution, both in
terms of implementation and design (I don't want a repeat of the
discussions regarding gis.m's zoom behaviour).

> 5. Minor glitch: the monitor's title bar.

That's because it isn't a monitor. I can set the window title to
whatever is desired.

-- 
Glynn Clements <glynn at gclements.plus.com>