[GRASS-dev] Re: [GRASS-user] scientific notation

[Hamish]

re. yesterday's v.in.ascii changes, rev 1.51
  http://freegis.org/cgi-bin/viewcvs.cgi/grass6/vector/v.in.ascii/in.c

"Changes since 1.50: +465 -425 lines
Run indent
Message standardization"



Please do not mix code changes with indent changes!
It makes it very hard to review the code changes.

SUBMITTING rule 15:
    Existing code should not be re-indented except in extreme cases, as this
    will make "diff" comparisons with older versions impossible. If indent is 
    needed, do not check in any changes other than the indentation in the same 
    commit! Do add the indent switches and any indent warning messages to the 
    CVS log. Any change or fix mixed in with an indent is very hard to track 
    making it hard for others to follow the change or fix any new bugs.



and changing the v.in.ascii columns= option to use
G_define_standard_option(G_OPT_COLUMNS) is not very safe as the standard option
is really meant for a different column= task. If in future someone changed the
parser.c definition for the intended task, v.in.ascii's option could change in
an undesirable way.


note that by doing that you have changed the name of the option in an
incompatible way-
v.in.ascii was:
    columns_opt->key = "columns";

while parser.c sets it to
        case G_OPT_COLUMNS:
            Opt->key          = "column";

Anyone who scripted "columns=" will now get an error.

(regardless of above, perhaps it would be a good idea to change G_OPT_COLUMNS
to key->"columns" in parser.c? the change would be backwards compatible as the
options work on minimum letter match)


thanks,
Hamish



      ____________________________________________________________________________________
Get easy, one-click access to your favorites. 
Make Yahoo! your homepage.
http://www.yahoo.com/r/hs