[GRASS-dev] iostream lib and r.terraflow/r.viewshed

[Paul Kelly]

On Thu, 10 Jul 2008, Glynn Clements wrote:

>
> Paul Kelly wrote:
>
>>>> it before Will moves r.terraflow into the iostream directory as
>>>> suggested by Paul.
>>>
>>> Can you provide details?
>>
>> Will is working on a new r.viewshed module which uses the same iostream
>> C++ library as r.terraflow. To avoid code duplication I suggested this
>> layout:
>> Have a subdirectory:
>> raster/iostream/
>> and within that lib/ r.terraflow/ r.viewshed/
>> One copy of the library in the lib directory - it compiles into a static
>> library which is then linked in by r.terraflow and r.viewshed.
>>
>> This is subject to revision/better ideas of course - when Will has the
>> r.viewshed code ready (I haven't seen it) maybe we can experiment with
>> it in grass-addons in the first instance.
>
> I suggest moving the iostream library to lib/iostream, rather than
> grouping r.terraflow and r.viewshed together.

I've made this change now in svn trunk, in preparation for adding 
r.viewshed to grass-addons and sharing the iostream library with 
r.terraflow. The iostream library had quite a lot of include files; I've 
put these in include/iostream rather than polluting the main GRASS 
include/ directory. I wasn't sure which ones were internal to the library 
and which ones are required by user programs, so have just included them 
all in include/ (that was the way it was done in the IOStream subdirectory 
of r.terraflow).

r.terraflow still compiles fine so I hope there will be no unforeseen 
consequences.

Paul