[GRASS-dev] A couple of r.colors ideas

[Markus Neteler]

On Wed, Aug 13, 2008 at 10:23 AM, Glynn Clements
<glynn at gclements.plus.com> wrote:
> Markus Neteler wrote:
>
>> >>> Added as r.colors.out.
>> >>
>> >> In trunk? Backported to develbranch_6?
>> >
>> > Trunk.
>> >
>> > It may need a G_find_cell2() call to work in 6.4. In 7.x, any libgis
>> > functions which deal with existing maps should accept "" for the
>> > mapset argument, eliminating the need for explicit G_find_* calls in
>> > most cases.
>> >
>> > On that front, r32633 should probably be back-ported. It fixes the
>> > case of passing qualified names to G__open[_misc] and G_read_colors().
>> >
>> > [Colour tables need special treatment because of the colr2 feature.
>> > The g3d library has a similar feature which is both more general and,
>> > AFAICT, seriously borked.]
>>
>> So,
>> http://trac.osgeo.org/grass/changeset/32633
>> should we do this? Any side effects?
>
> That should be safe.
>
> There's also r32717 (which requires r32715) and r32735. Both of those
> should be safe (r32715 definitely is, and can be committed
> independently of the other two).

All r32715, r32717 and r32735 are backported now.

> I'm now reasonably sure that all library functions which accept a name
> and mapset will accept an empty mapset ("") with either a qualified or
> unqualified name.
>
> The only exceptions are G__file_name() and G__file_name_misc(), which
> need to be able to construct filenames for maps which are in the
> process of being created, so they can't use G_find_file() etc.


Markus