[GRASS-dev] Re: [GRASS GIS] #399: Added "backlink" functionality to r.walk, r.cost & r.drain

[GRASS GIS]

#399: Added "backlink" functionality to r.walk, r.cost & r.drain
--------------------------+-------------------------------------------------
  Reporter:  cnielsen     |       Owner:  grass-dev at lists.osgeo.org
      Type:  enhancement  |      Status:  new                      
  Priority:  major        |   Milestone:  6.4.0                    
 Component:  Raster       |     Version:  unspecified              
Resolution:               |    Keywords:                           
  Platform:  All          |         Cpu:  All                      
--------------------------+-------------------------------------------------
Changes (by hamish):

  * type:  defect => enhancement

Comment:

 Hi,

 thanks for the patches,

 some comments & cleanups:

  - don't use C++ style //comments  (see the SUBMITTING file)
  - please run tools/grass_indent.sh on the code (see SUBMITTING...)
  - comments like "//cn:added;" are redundant and should be removed. that
 info & source heritage is available through the SVN history, which can be
 annotated line by line in the viewVc web interface. a rule there is if it
 doesn't help explain the code, it is noise which helps clutter & obfuscate
 the code.
  - the GRASS convention for angle is to use Cartesian theta, i.e. degrees
 are counted CCW from East, not compass-style CW from North. Convert with "
 90-angle".
  - do not remove (valid) documentation from the help pages lightly, and
 certainly do not remove prior authors from the AUTHORS section of the help
 page! (I spotted Roger Miller was removed, maybe others) If you are unsure
 <!-- comment it out -->.


 Hamish

-- 
Ticket URL: <https://trac.osgeo.org/grass/ticket/399#comment:1>
GRASS GIS <http://grass.osgeo.org>