[GRASS-dev] Re: [GRASS GIS] #73: r.out.gdal tiff output does not
work
GRASS GIS
trac at osgeo.org
Thu Dec 18 04:12:03 EST 2008
#73: r.out.gdal tiff output does not work
--------------------------+-------------------------------------------------
Reporter: helena | Owner: grass-dev at lists.osgeo.org
Type: defect | Status: new
Priority: critical | Milestone: 6.4.0
Component: Raster | Version: svn-trunk
Resolution: | Keywords: r.out.gdal, tiff
Platform: Unspecified | Cpu: Unspecified
--------------------------+-------------------------------------------------
Comment (by mmetz):
Replying to [comment:29 hamish]:
> FWIW, it was just minor whitespace on roughly 5 lines. I don't think it
is necessary to run intent compulsively as long as the whitespace doesn't
get too abused.
>
The question is, keep the GRASS source code in standard format yes or no?
According to the discussion on it and to SUBMITTING, the answer is
something like "YES, we had a long discussion on it, reformatting the
whole source code was a major change, now please be so kind as to keep the
code in the standard format" and not "Yes, but a little deviation here and
there doesn't harm". No offense! My patch would introduce some new code,
that's why I ran indent on it, otherwise I would have been told to do so
first before proposing a patch.
Justification for the patch: the TODO's in the code have been attended to;
that would avoid quite a few of the problems reported in this very long
ticket and IMHO the module could be regarded as working all right if these
TODO's are solved.
I replaced the attached patch with a new patch against the newly formatted
r.out.gdal
Markus M
--
Ticket URL: <http://trac.osgeo.org/grass/ticket/73#comment:30>
GRASS GIS <http://grass.osgeo.org>
More information about the grass-dev
mailing list