[GRASS-dev] Re: [GRASS GIS] #197: sfd support for r.terraflow

[GRASS GIS]

#197: sfd support for r.terraflow
--------------------------+-------------------------------------------------
  Reporter:  adanner      |       Owner:  grass-dev at lists.osgeo.org
      Type:  defect       |      Status:  new                      
  Priority:  major        |   Milestone:  7.0.0                    
 Component:  Raster       |     Version:  svn-trunk                
Resolution:               |    Keywords:  terraflow r.terraflow    
  Platform:  Unspecified  |         Cpu:  Unspecified              
--------------------------+-------------------------------------------------
Changes (by adanner):

  * version:  svn-develbranch6 => svn-trunk
  * milestone:  6.4.0 => 7.0.0

Comment:

 Replying to [comment:6 glynn]:
 > Replying to [comment:5 adanner]:
 >
 > > If you want, I can throw the code from tflowopt.c back into main.cc
 and then you'll get 30+ warning about how terraflow is trying to connect
 to the rest of Grass.
 >
 > That is my preference.
 >

 new patch uploaded. Patch is now against svn-trunk, but the changes can be
 merged back to 6.4.0.
 I updated the milestone and version tags.

 > > This seems excessive, since there currently is no right way to fix a
 C-style interface in C++ without bloating the code and making it
 unreadable.
 >
 > Correct. Which is why the interface needs to be fixed in C; i.e. add the
 "const" to the fields of "struct Option" in gis.h. Having the compiler
 remind people about this on a regular basis is the best way to make it
 happen.
 >
 > Actually, I'll look into that side of it now.

 Thanks, that eliminates many of the warnings. There are only four left on
 options->answer, but I'm content with only four warnings. Fixing those
 last four require some tedious buffer creation/copying.

-- 
Ticket URL: <http://trac.osgeo.org/grass/ticket/197#comment:8>
GRASS GIS <http://grass.osgeo.org>