[GRASS-dev] simwe

[Helena Mitasova]

On Oct 30, 2008, at 5:56 PM, Glynn Clements wrote:

>
> Helena Mitasova wrote:
>
>> The sites issues are fixed (I commented the offending code out).
>
> By "fixed", I meant making the code work.

the site related input and output is not essential and needs to be
updated to vector points anyway so I commented it out (until
somebody who is interested in having that output will update
it to vector format - it may be me, my student or somebody else).

So the #1 and #2 is not there any more. Let me know if I should delete
it completely rather than comment it out - I am keeping it there in case
I can get to it sometimes soon.

The waterglobs.h issue is more complicated and I need to find out first
why it has been done the way it is there - I need more time for that,
but the code should compile and work as it is (at least it does for me).

Helena
>
> AFAICT, there are two main issues:
>
> 1. fdoutwalk is a sites handle, but it's never closed. This wasn't
> necessary when it was a FILE*, as it was automatically closed on exit,
> but I think that it's necessary for a vector map.
>
> 2. fw is a plain FILE* (for simwe_data.txt), but it's being closed
> with G_sites_close().
>
> The "meta" issue is that the extensive use of global variables (and
> the use of multiple versions of waterglobs.h) makes life hard for
> anyone who isn't intimately acquainted with the code to do anything
> with it. Which is why I didn't try to fix the above (mainly #1; it's
> hard to figure out where to put the G_sites_close() call).
>
> -- 
> Glynn Clements <glynn at gclements.plus.com>
> _______________________________________________
> grass-dev mailing list
> grass-dev at lists.osgeo.org
> http://lists.osgeo.org/mailman/listinfo/grass-dev