[GRASS-dev] Re: About the vector changes

Markus Metz markus.metz.giswork at googlemail.com
Thu Aug 13 03:28:55 EDT 2009


Glynn Clements wrote:
> Markus Neteler wrote:
>
>   
>>>> I got carried away (replacing all fseek/ftell occurrences I could find
>>>> with G_fseek/G_ftell, adjusting off_t as you showed above) and also made
>>>> r3.in|out.v5d LFS-safe, but did not submit. Should I?
>>>>         
>>> Yes; ideally, we should use G_{fseek,ftell} everywhere.
>>>       
>> Patch attached.
>>
>>     
>
>   
[...]
> I've committed this (with fixes) as r38703.
>   
Do the Makefiles for the modules also need fixing with

ifneq ($(USE_LARGEFILES),)
EXTRA_CFLAGS = -D_FILE_OFFSET_BITS=64
endif

or is -D_FILE_OFFSET_BITS=64 now set globally in COMPILE_FLAGS and 
COMPILE_FLAGS_XX or similar?

Markus M

> lib/rst/inter_float still needs to be fixed to use off_t for offsets.
> Currently, it's using "int", so it won't handle files >2GiB even on
> 64-bit platforms.
>
>   


More information about the grass-dev mailing list