[GRASS-dev] Re: [GRASS GIS] #676: r.watershed: different output map options do not allow for fully qualified map names

[GRASS GIS]

#676: r.watershed: different output map options do not allow for fully qualified
map names
-----------------------+----------------------------------------------------
  Reporter:  mlennert  |       Owner:  grass-dev at lists.osgeo.org
      Type:  defect    |      Status:  new                      
  Priority:  normal    |   Milestone:  6.4.0                    
 Component:  Raster    |     Version:  6.4.0 RCs                
Resolution:            |    Keywords:  r.watershed              
  Platform:  Linux     |         Cpu:  Unspecified              
-----------------------+----------------------------------------------------
Comment (by mlennert):

 Replying to [comment:7 glynn]:
 > Replying to [comment:6 mlennert]:
 >
 > > IIUC, the problem actually comes from the use of G_legal_filename() in
 these modules (r.reclass is another of them). So the question is: should
 modules check for legality of given file names ?
 >
 > File names or map names?

 I meant map names.

 >
 > > And if yes, should they use G_legal_filename().
 >
 > Modules shouldn't normally use this function. It's meant for use by low-
 level library functions.

 Can we just delete the check then ? In any case there will be an error at
 creation if the map name is illegal, or ?


 > If modules are passing map names to it, the modules should be fixed.

 Grepping for G_legal_filename in grass6 (trunk and 64 releasebranch)
 throws up lots of occurences which at first sight seem to pass map names.
 None left in grass7, so I guess you have already cleaned up ?

 Should this also be done in 6.* ?

 Moritz

-- 
Ticket URL: <https://trac.osgeo.org/grass/ticket/676#comment:8>
GRASS GIS <http://grass.osgeo.org>