[GRASS-dev] fix linkage on python binding patch?

Glynn Clements glynn at gclements.plus.com
Thu Apr 22 13:02:32 EDT 2010


Markus Neteler wrote:

> in the Mandriva Cooker SVN, I have seen this patch to RC6:
> 
> http://svn.mandriva.com/cgi-bin/viewvc.cgi/packages/cooker/grass/current/SOURCES/grass-6.4.0RC6-fix-link.patch?view=markup
> 
> fix linkage on python binding
> 
> 1 	--- swig/python/Makefile.link 2010-04-04 06:07:01.000000000 +0200
> 2 	+++ swig/python/Makefile 2010-04-04 06:07:17.000000000 +0200
> 3 	@@ -39,6 +39,7 @@
> 4 	EXTRA_SWIG = ../include/python/my_typemaps.i ../include/python/common.i
> 5 	SWIGFLAGS = $(ARCH_INC) -I../include/python -outdir .
> 6 	EXTRA_CFLAGS = $(PYMOD_CFLAGS)
> 7 	+EXTRA_LIBS = $(PYTHONLDFLAGS)
> 8 	EXTRA_CLEAN_FILES := $(foreach M,$(MODULES),$(M)_wrap.o $(M)_wrap.c
> $(M).pyc $(M).py _$(M).so)
> 9 	CLEAN_SUBDIRS = NumPtr
> 
> Should we include it?

$(PYTHONLDFLAGS) is already be added by the _%.so rule in Python.make. 
If there's a problem, maybe $(PYMOD_LDFLAGS) needs to be moved to the
right?

-- 
Glynn Clements <glynn at gclements.plus.com>


More information about the grass-dev mailing list