[GRASS-dev] fix linkage on python binding patch?

[William Kyngesburye]

On Apr 22, 2010, at 12:02 PM, Glynn Clements wrote:

> 
> Markus Neteler wrote:
> 
>> in the Mandriva Cooker SVN, I have seen this patch to RC6:
>> 
>> http://svn.mandriva.com/cgi-bin/viewvc.cgi/packages/cooker/grass/current/SOURCES/grass-6.4.0RC6-fix-link.patch?view=markup
>> 
>> fix linkage on python binding
>> 
>> 1 	--- swig/python/Makefile.link 2010-04-04 06:07:01.000000000 +0200
>> 2 	+++ swig/python/Makefile 2010-04-04 06:07:17.000000000 +0200
>> 3 	@@ -39,6 +39,7 @@
>> 4 	EXTRA_SWIG = ../include/python/my_typemaps.i ../include/python/common.i
>> 5 	SWIGFLAGS = $(ARCH_INC) -I../include/python -outdir .
>> 6 	EXTRA_CFLAGS = $(PYMOD_CFLAGS)
>> 7 	+EXTRA_LIBS = $(PYTHONLDFLAGS)
>> 8 	EXTRA_CLEAN_FILES := $(foreach M,$(MODULES),$(M)_wrap.o $(M)_wrap.c
>> $(M).pyc $(M).py _$(M).so)
>> 9 	CLEAN_SUBDIRS = NumPtr
>> 
>> Should we include it?
> 
> $(PYTHONLDFLAGS) is already be added by the _%.so rule in Python.make. 
> If there's a problem, maybe $(PYMOD_LDFLAGS) needs to be moved to the
> right?
> 
And PYTHONLDFLAGS messes up the OS X build.  Python.make conditionally adds it to PYMOD_LDFLAGS.


-----
William Kyngesburye <kyngchaos*at*kyngchaos*dot*com>
http://www.kyngchaos.com/

[Trillian]  What are you supposed to do WITH a maniacally depressed robot?

[Marvin]  You think you have problems?  What are you supposed to do if you ARE a maniacally depressed robot?  No, don't try and answer, I'm 50,000 times more intelligent than you and even I don't know the answer...

- HitchHiker's Guide to the Galaxy