[GRASS-dev] Re: [GRASS GIS] #1131: Global LFS for wingrass

[GRASS GIS]

#1131: Global LFS for wingrass
--------------------------+-------------------------------------------------
 Reporter:  mmetz         |       Owner:  grass-dev@…              
     Type:  defect        |      Status:  new                      
 Priority:  critical      |   Milestone:  7.0.0                    
Component:  libgis        |     Version:  svn-trunk                
 Keywords:  LFS,wingrass  |    Platform:  MSWindows 7              
      Cpu:  All           |  
--------------------------+-------------------------------------------------

Comment(by mmetz):

 Replying to [comment:2 glynn]:
 > Replying to [comment:1 mmetz]:
 >
 > > Following up previous discussions, I have removed struct stat where
 possible. The changes needed for LFS with wingrass are in config.h.in but
 still inactive.
 > >
 > > Glynn, could you please check if I messed up something somewhere (all
 the struct stat related changes and config.h.in)?
 >
 > The config.h.in changes seem okay.

 They were not. STRUCT_STAT needs the be always defined, fixed.

 > Although, I would omit the aliases for seek() and tell()

 Done.
 >
 > I don't see any "struct stat" changes. Currently, 7.0 has references to
 "struct stat" in:
 {{{
 > display/d.font/main.c
 > general/g.access/get_perms.c
 > general/g.mkfontcap/freetype_fonts.c
 > include/gisdefs.h
 > include/iostream/ami_stream.h
 > lib/db/dbmi_base/isdir.c
 > lib/gis/copy_dir.c
 > lib/gis/mapset_msc.c
 > lib/gis/mapset_nme.c
 > lib/gis/paths.c
 > lib/gis/remove.c
 > lib/gis/user_config.c
 > lib/init/clean_temp.c
 > lib/vector/Vlib/open.c
 > lib/vector/dglib/examples/parse.c
 > lib/vector/diglib/file.c
 > raster/r.li/r.li.daemon/daemon.c
 > vector/v.mapcalc/map.c
 }}}

 That was the first step, to get some feedback without actually changing
 anything. In theory, LFS for wingrass is now working as of r43115 in
 trunk. In practice, global LFS in trunk is working as before on Linux.

 Some remarks:

 Everything related to fonts: the stat'ed file might be opened by another
 program?
 {{{
 general/g.mkfontcap/freetype_fonts.c
 display/d.font/main.c
 }}}

 Shouldn't the check here also check if path is a dir?
 {{{
 lib/gis/mapset_nme.c
 }}}

 Needs some cleaning up, unused functions (coor file is never loaded to
 memory).
 {{{
 lib/vector/diglib/file.c
 }}}

 There is a temporary check for LFS hidden in v.info, visible with DEBUG=1.

 Markus M

-- 
Ticket URL: <http://trac.osgeo.org/grass/ticket/1131#comment:3>
GRASS GIS <http://grass.osgeo.org>