[GRASS-dev] Re: [GRASS GIS] #1131: Global LFS for wingrass
GRASS GIS
trac at osgeo.org
Sat Aug 14 16:15:50 EDT 2010
#1131: Global LFS for wingrass
--------------------------+-------------------------------------------------
Reporter: mmetz | Owner: grass-dev@…
Type: defect | Status: new
Priority: critical | Milestone: 7.0.0
Component: libgis | Version: svn-trunk
Keywords: LFS,wingrass | Platform: MSWindows 7
Cpu: All |
--------------------------+-------------------------------------------------
Comment(by glynn):
Replying to [comment:3 mmetz]:
> Some remarks:
>
> Everything related to fonts: the stat'ed file might be opened by another
program?
{{{
general/g.mkfontcap/freetype_fonts.c
display/d.font/main.c
}}}
This only tests for existence and type. Ideally, we should have e.g.
G_file_exists(), G_file_is_file() and G_file_is_directory() and use those
(the last two need a flag to indicate whether to use stat() or lstat()).
That would probably eliminate many of the stat() calls. Also,
G_file_size(). It's better to keep as much of this in the library as
possible.
> Shouldn't the check here also check if path is a dir?
{{{
lib/gis/mapset_nme.c
}}}
It should check that WIND is a file, rather than checking that it isn't a
directory.
--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1131#comment:6>
GRASS GIS <http://grass.osgeo.org>
More information about the grass-dev
mailing list