[GRASS-dev] Re: [GRASS GIS] #660: v.delaunay producing incorrect results

[GRASS GIS]

#660: v.delaunay producing incorrect results
-----------------------+----------------------------------------------------
  Reporter:  cmbarton  |       Owner:  grass-dev at lists.osgeo.org
      Type:  defect    |      Status:  closed                   
  Priority:  critical  |   Milestone:  6.4.0                    
 Component:  Vector    |     Version:  6.4.0 RCs                
Resolution:  fixed     |    Keywords:  delaunay                 
  Platform:  MacOSX    |         Cpu:  OSX/Intel                
-----------------------+----------------------------------------------------
Comment (by hamish):

 Nice.

 How does it perform when the number of input points > 10,000 (& up to
 ~3M)? which was where the old v.delaunay1 fell over?


 re. the patch, three minor comments after a cursory look.
  1) MarkusM, you is the man, congrats
  2) TRUE=1, FALSE=0 is defined by gis.h, no need to repeat it.
  3) cmp_v() appears to test two FP values with ==. Should it use
 {{{
  if( fabs(val1 - val2) < GRASS_EPSILON )
 }}}
 instead? Is it looking for itself or another point at the same place as it
 is?



 Hamish

-- 
Ticket URL: <https://trac.osgeo.org/grass/ticket/660#comment:39>
GRASS GIS <http://grass.osgeo.org>