[GRASS-dev] Re: [GRASS GIS] #974: [Patch] add option to d.vect to make symbol size proportionate to square root of size_column

[GRASS GIS]

#974: [Patch] add option to d.vect to make symbol size proportionate to square
root of size_column
--------------------------+-------------------------------------------------
  Reporter:  mlennert     |       Owner:  grass-dev at lists.osgeo.org
      Type:  enhancement  |      Status:  new                      
  Priority:  normal       |   Milestone:  7.0.0                    
 Component:  Display      |     Version:  unspecified              
Resolution:               |    Keywords:                           
  Platform:  Unspecified  |         Cpu:  Unspecified              
--------------------------+-------------------------------------------------
Comment (by hamish):

 (trac is logging me out every 5 minutes and it's driving me nuts!)


 Hi,

 I'm fine with the patch, a couple of comments though,

  - patches are '''''much''''' easier to review if they are kept to just
 the change you are talking about. ie gratuitous whitespace changes should
 be put in another patch if at all. signal:noise ratios & wasted time ...

  - please don't run the indent script unless you've added a bunch of new
 code which needs it. see the comments in the SUBMITTING file.

  - if using sqrt() please #include <math.h>

  - sqrt_flag->description: please split into two parts: short description
 on flag->label= line and "i.e." on flag->description= line (it becomes the
 tooltip).


 non-specific comments-
  - I worry that the d.vect interface is becoming like a 747 cockpit for
 new users. So many controls it becomes overwhelming. the solution I guess
 is good use of tabs and specific task wrapper scripts (eg addons
 d.stations and d.varea).

  - now that d.vect has support for sizecol, rgbcol, widthcol, zcolor, etc,
 what is left for d.thematic.linepoint to do?


 cheers,
 Hamish

-- 
Ticket URL: <https://trac.osgeo.org/grass/ticket/974#comment:1>
GRASS GIS <http://grass.osgeo.org>