[GRASS-dev] configure.in: quotation marks

Glynn Clements glynn at gclements.plus.com
Tue Oct 25 13:23:10 EDT 2011


Martin Landa wrote:

> what's the purpose of quotation marks around `$prefix`?
> 
> configure.in:
> 
>    166      INSTDIR='${prefix}'"/GRASS-${GRASS_VERSION_MAJOR}.${GRASS_VERSION_MINOR}.app/Contents/MacOS"
>    168      INSTDIR='${prefix}'"/grass-${GRASS_VERSION_MAJOR}.${GRASS_VERSION_MINOR}.${GRASS_VERSION_RELEASE}"

To prevent ${prefix} from being expanded in the resulting
Platform.make file.

> the result is
> 
>  Installation directory:      ${prefix}/grass-7.0.svn
> 
> which is not really informative.
> 
> I would suggest to remove these quotation marks in configure.log.

The current behaviour is intentional; it allows e.g.
"make install prefix=..." to work as expected.

The fact that make variables can be overriden on the command line
is[1] a significant factor in how Makefiles are structured.

[1] At least, it /should/ be a factor. Whether or not it actually is
depends upon whether the Makefile's author "gets" make.

-- 
Glynn Clements <glynn at gclements.plus.com>


More information about the grass-dev mailing list