[GRASS-dev] [GRASS GIS] #1637: r.pack and fully qualified input

GRASS GIS trac at osgeo.org
Fri Apr 6 11:08:18 EDT 2012


#1637: r.pack and fully qualified input
-------------------------+--------------------------------------------------
 Reporter:  martinl      |       Owner:  grass-dev@…              
     Type:  defect       |      Status:  new                      
 Priority:  major        |   Milestone:  6.4.3                    
Component:  Raster       |     Version:  svn-releasebranch64      
 Keywords:  r.pack       |    Platform:  Linux                    
      Cpu:  Unspecified  |  
-------------------------+--------------------------------------------------
 Recently added `r.pack` doesn't support fully qualified input maps, e.g.

 {{{
 r.pack input=aspect at PERMANENT
 ERROR: No map components found
 }}}

 When copying files the script expects that `GIS_OPT_INPUT` is not fully
 qualified name
 source:grass/branches/releasebranch_6_4/scripts/r.pack/r.pack#L92

 {{{
 91      for ELEMENT in cats cell cellhd colr fcell grid3 hist ; do
 92          if [ -e "$BASEDIR/$ELEMENT/$GIS_OPT_INPUT" ] ; then
 93              cp "$BASEDIR/$ELEMENT/$name" "$TMP_DIR/$ELEMENT"
 94          fi
 95      done
 }}}

 One thing related, I would expect that

 {{{
 g.findfile elem=cell file=aspect at PERMANENT
 }}}

 return

 {{{
 name='aspect'
 mapset='PERMANENT'
 fullname='aspect at PERMANENT'
 ...
 }}}

 and not

 {{{
 name='aspect at PERMANENT'
 mapset='PERMANENT'
 fullname='aspect at PERMANENT'
 ...
 }}}

 In the case that `g.findfile` would return not fully-qualified `name` we
 could simply reuse it in the script. I think that changing `g.findfile` in
 G6/G7 to report always non-qualified name should be harmless, in other
 words, it should not break any scripts written for G6. What do you think?

-- 
Ticket URL: <http://trac.osgeo.org/grass/ticket/1637>
GRASS GIS <http://grass.osgeo.org>



More information about the grass-dev mailing list