[GRASS-dev] [GRASS GIS] #1888: r.terraflow won't run

[Anna Kratochvílová]

On Tue, Feb 19, 2013 at 12:56 PM, Paulo van Breugel
<p.vanbreugel at gmail.com> wrote:
> Hi Anna,
>
> I am not sure what you mean with 'special case'? The error message appears
> when I try to open the r.terraflow gui, i.e., before I can set any value.

With the special case I mean the default value 'infinity' when the
option is defined as TYPE_DOUBLE

>
> Just to add, it works for me in GRASS 6.4 (running it right now), so I would
> assume it has something to do how this is implemented in GRASS 7.0?

The difference is that in 6.4 we use TextCtrl in dialogs for float
values, but in 7 it was changed to use FloatSpin control (see for
example d.vect symbol size option). So text 'infinity' is completely
ok for TextCtrl but not for a control expecting numbers.
I don't know, maybe we should go back and use the TextCtrl widget?

>
> Cheers,
>
> Paulo
>
>
> On Tue, Feb 19, 2013 at 12:39 PM, GRASS GIS <trac at osgeo.org> wrote:
>>
>> #1888: r.terraflow won't run
>>
>> --------------------------------+-------------------------------------------
>>  Reporter:  pvanbosgeo          |       Owner:  grass-dev@…
>>      Type:  defect              |      Status:  new
>>  Priority:  normal              |   Milestone:  7.0.0
>> Component:  wxGUI               |     Version:  svn-trunk
>>  Keywords:  r.terraflow, forms  |    Platform:  Unspecified
>>       Cpu:  Unspecified         |
>>
>> --------------------------------+-------------------------------------------
>>
>> Comment(by annakrat):
>>
>>  The problem is that r.terraflow option ''d8cut'' has default value
>>  'infinity'. The gui expects float and not string. Inside r.terraflow
>>  answer infinity means
>>
>>  {{{
>>  static const flowaccumulation_type MAX_ACCU = 1e+15;
>>  }}}
>>
>>  I am not sure how to handle this special case. We can test 'infinity'
>>  string and set maximum value of the Float Spin instead (which is
>> currently
>>  1e9, but it can be increased).
>>
>>  Anna
>>
>> --
>> Ticket URL: <http://trac.osgeo.org/grass/ticket/1888#comment:2>
>> GRASS GIS <http://grass.osgeo.org>
>>
>
>
> _______________________________________________
> grass-dev mailing list
> grass-dev at lists.osgeo.org
> http://lists.osgeo.org/mailman/listinfo/grass-dev