[GRASS-dev] [GRASS GIS] #957: v.voronoi has extra lines in output

[GRASS GIS]

#957: v.voronoi has extra lines in output
-----------------------+----------------------------------------------------
 Reporter:  helena     |       Owner:  grass-dev@…              
     Type:  defect     |      Status:  new                      
 Priority:  major      |   Milestone:  6.4.4                    
Component:  Vector     |     Version:  svn-releasebranch64      
 Keywords:  v.voronoi  |    Platform:  All                      
      Cpu:  All        |  
-----------------------+----------------------------------------------------

Comment(by mlennert):

 Replying to [comment:36 mmetz]:
 > Replying to [comment:32 mlennert]:
 > > Replying to [comment:31 mmetz]:
 > > > Replying to [comment:30 mmetz]:
 > > > > Replying to [comment:28 mlennert]:
 > > > > > In 64release, I'm still getting a subset of the holes reported
 by Helena in a raster resulting from v.voronoi polygons
 > > > > > [...] although the vector polygons all look ok.
 > > > > >
 > > > >
 > > > > That is a bug in v.to.rast, more specifically in G_plot_polygon()
 in lib/gis/plot.c.
 > > >
 > > > Please try trunk r57839.
 > >
 > > Solves it for me, thanks !
 > >
 > > As this wasn't even a v.voronoi bug, I think this bug report can
 probably be closed, unless you want to keep it open as a reminder to erase
 the empty functions. Is there an agreement on erasing them ? If yes, I'm
 willing to do it.
 >
 > I think these functions can be removed.

 Done in rXXXXXX for those directly at the spot Hamish mentioned. But I
 discovered another:
 [https://trac.osgeo.org/grass/browser/grass/trunk/vector/v.voronoi/sw_output.c#L65
 out_vertex]

 and two that become empty (except for a conditional test) when the first
 round is erased:
 [https://trac.osgeo.org/grass/browser/grass/trunk/vector/v.voronoi/sw_output.c#L27
 out_bisector] and
 [https://trac.osgeo.org/grass/browser/grass/trunk/vector/v.voronoi/sw_output.c#L78
 out_site]

 I'll attach a diff with all the changes erasing these functions entails.
 Everything seems to work here, but before submitting this, I would like
 someone else to have a look and test.

 Moritz

 This is actually called from

-- 
Ticket URL: <https://trac.osgeo.org/grass/ticket/957#comment:37>
GRASS GIS <http://grass.osgeo.org>