[GRASS-dev] [GRASS GIS] #2024: r.li.setup generates incomplete r.li conf file

GRASS GIS trac at osgeo.org
Tue Feb 4 11:51:47 PST 2014


#2024: r.li.setup generates incomplete r.li conf file
------------------------+---------------------------------------------------
 Reporter:  matmar      |       Owner:  rashadkm           
     Type:  defect      |      Status:  assigned           
 Priority:  normal      |   Milestone:  6.4.4              
Component:  Raster      |     Version:  svn-releasebranch64
 Keywords:  r.li.setup  |    Platform:  Linux              
      Cpu:  x86-64      |  
------------------------+---------------------------------------------------
Changes (by hamish):

 * cc: lucadelu (added)


Comment:

 Hi,

 > Changeset 58878
 > Timestamp:
 >    02/04/14 07:09:15 (5 hours ago)
 > Author:
 >    lucadelu
 >
 > Message:
 >    r.li.setup: removed duplicate cat for same features

 {{{
 Index:
 grass/branches/releasebranch_6_4/raster/r.li/r.li.setup/sample_area_vector.sh
 ===================================================================
 ---
 a/grass/branches/releasebranch_6_4/raster/r.li/r.li.setup/sample_area_vector.sh
 +++
 b/grass/branches/releasebranch_6_4/raster/r.li/r.li.setup/sample_area_vector.sh
 @@ -2,3 +2,3 @@
 -#!/bin/bash
 +#!/bin/bash -x
  #
  # This program is free software under the GPL (>=v2)
 @@ -57,5 +57,5 @@

  #using v.category instead of v.build with cdump
 -v.category input=$GIS_OPT_vector option=print > $TMP.cat
 +v.category input=$GIS_OPT_vector option=print | sort | uniq > $TMP.cat

  #get input vector name
 }}}


 I'm copying this patch here as it will surely be dropped and forgotten
 otherwise.


 some general requests to all,

 Please avoid to commit changes to G6 tcl/shell r.li.setup until I have
 finished my merge (collect patches here instead), and please commit to the
 dev branch first then backport to the stable branch only once the change
 is fully tested and you are willing to sign it off. It's hard to keep
 track of what work needs to be done and use the automated branch-merge
 tools otherwise (and without those maintaining multiple branches is a real
 pain).

 Also, it is best to always "quote" shell script $VARIABLES, especially
 when they contain filenames which can often have spaces in their path.


 thanks,
 Hamish

-- 
Ticket URL: <https://trac.osgeo.org/grass/ticket/2024#comment:16>
GRASS GIS <http://grass.osgeo.org>



More information about the grass-dev mailing list