[GRASS-dev] [GRASS-SVN] r61280 - in grass/trunk/gui: icons/grass wxpython/lmgr
Vaclav Petras
wenzeslaus at gmail.com
Sat Jul 19 10:18:49 PDT 2014
Hi,
I've realized that an nice icon will save me a lot of time in searching for
the right layer/item in layer manager layer tree, so I've just added new
icons derived from the SVG version of current icons [1] which are contain
only symbol for type of the layer and not unnecessary symbol for layer nor
unwanted symbol for add.
I've used size 16x16, although other icons are 24x24 (from what I've
checked). The reason is that 24x24 were resampled in very ugly way (this is
what also the former icons suffered from). I don't know how to deal with
this inconsistency without complete redesign of icon handling in wxGUI.
I'm not sure what to do with SVGs. Should I try to put them to OSGeo
repository? Is creating ticket the right way?
Future work is to create this kind of icon for command layer and for grid
layer which don't have SVG version in OSGeo repository. Additional future
work is to determine if these icons are useful also somewhere else.
This commit should not be backported soon because I'm not sure about side
effects because of the way of using the defined icons.
Vaclav
[1] http://svn.osgeo.org/osgeo/graphics/trunk/
[2] trac.osgeo.org/osgeo/browser/graphics/trunk/
On Sat, Jul 19, 2014 at 12:58 PM, <svn_grass at osgeo.org> wrote:
>
> Author: wenzeslaus
> Date: 2014-07-19 09:58:44 -0700 (Sat, 19 Jul 2014)
> New Revision: 61280
>
> Added:
> grass/trunk/gui/icons/grass/aspect-arrow.png
> grass/trunk/gui/icons/grass/cell-cats.png
> grass/trunk/gui/icons/grass/his.png
> grass/trunk/gui/icons/grass/label.png
> grass/trunk/gui/icons/grass/raster.png
> grass/trunk/gui/icons/grass/raster3d.png
> grass/trunk/gui/icons/grass/rgb.png
> grass/trunk/gui/icons/grass/shaded-relief.png
> grass/trunk/gui/icons/grass/vector-chart.png
> grass/trunk/gui/icons/grass/vector-thematic.png
> grass/trunk/gui/icons/grass/vector.png
> grass/trunk/gui/icons/grass/wms.png
> Modified:
> grass/trunk/gui/wxpython/lmgr/layertree.py
> Log:
> wxGUI: icons for layers in lmgr tree without 'layer' and 'add' symbols
>
> Size of icons is 16x16 to avoid imperfect resampling at some (or all)
platforms.
> The motivation is to make the icons more useful, they now can actually
help to recognize type of layer.
> The commit assumes that the icon objects defined in layertree are used
only for layers, not for other things although item label suggests that.
> Command and grid layer still use the layer-xxx-add icon because there is
no SVG for them in OSGeo icons (trac.osgeo.org/osgeo/browser/graphics/trunk/
).
> Geodesic and rhumbline layers are already using an icon with this style
(the same icon, actually).
>
> Added: grass/trunk/gui/icons/grass/aspect-arrow.png
> ===================================================================
> (Binary files differ)
>
>
> Property changes on: grass/trunk/gui/icons/grass/aspect-arrow.png
> ___________________________________________________________________
> Added: svn:mime-type
> + image/png
>
> Added: grass/trunk/gui/icons/grass/cell-cats.png
> ===================================================================
> (Binary files differ)
>
>
> Property changes on: grass/trunk/gui/icons/grass/cell-cats.png
> ___________________________________________________________________
> Added: svn:mime-type
> + image/png
>
> Added: grass/trunk/gui/icons/grass/his.png
> ===================================================================
> (Binary files differ)
>
>
> Property changes on: grass/trunk/gui/icons/grass/his.png
> ___________________________________________________________________
> Added: svn:mime-type
> + image/png
>
> Added: grass/trunk/gui/icons/grass/label.png
> ===================================================================
> (Binary files differ)
>
>
> Property changes on: grass/trunk/gui/icons/grass/label.png
> ___________________________________________________________________
> Added: svn:mime-type
> + image/png
>
> Added: grass/trunk/gui/icons/grass/raster.png
> ===================================================================
> (Binary files differ)
>
>
> Property changes on: grass/trunk/gui/icons/grass/raster.png
> ___________________________________________________________________
> Added: svn:mime-type
> + image/png
>
> Added: grass/trunk/gui/icons/grass/raster3d.png
> ===================================================================
> (Binary files differ)
>
>
> Property changes on: grass/trunk/gui/icons/grass/raster3d.png
> ___________________________________________________________________
> Added: svn:mime-type
> + image/png
>
> Added: grass/trunk/gui/icons/grass/rgb.png
> ===================================================================
> (Binary files differ)
>
>
> Property changes on: grass/trunk/gui/icons/grass/rgb.png
> ___________________________________________________________________
> Added: svn:mime-type
> + image/png
>
> Added: grass/trunk/gui/icons/grass/shaded-relief.png
> ===================================================================
> (Binary files differ)
>
>
> Property changes on: grass/trunk/gui/icons/grass/shaded-relief.png
> ___________________________________________________________________
> Added: svn:mime-type
> + image/png
>
> Added: grass/trunk/gui/icons/grass/vector-chart.png
> ===================================================================
> (Binary files differ)
>
>
> Property changes on: grass/trunk/gui/icons/grass/vector-chart.png
> ___________________________________________________________________
> Added: svn:mime-type
> + image/png
>
> Added: grass/trunk/gui/icons/grass/vector-thematic.png
> ===================================================================
> (Binary files differ)
>
>
> Property changes on: grass/trunk/gui/icons/grass/vector-thematic.png
> ___________________________________________________________________
> Added: svn:mime-type
> + image/png
>
> Added: grass/trunk/gui/icons/grass/vector.png
> ===================================================================
> (Binary files differ)
>
>
> Property changes on: grass/trunk/gui/icons/grass/vector.png
> ___________________________________________________________________
> Added: svn:mime-type
> + image/png
>
> Added: grass/trunk/gui/icons/grass/wms.png
> ===================================================================
> (Binary files differ)
>
>
> Property changes on: grass/trunk/gui/icons/grass/wms.png
> ___________________________________________________________________
> Added: svn:mime-type
> + image/png
>
> Modified: grass/trunk/gui/wxpython/lmgr/layertree.py
> ===================================================================
> --- grass/trunk/gui/wxpython/lmgr/layertree.py 2014-07-19 14:56:40 UTC
(rev 61279)
> +++ grass/trunk/gui/wxpython/lmgr/layertree.py 2014-07-19 16:58:44 UTC
(rev 61280)
> @@ -70,23 +70,23 @@
> label = _('Add command layer')),
> 'quit' : MetaIcon(img = 'quit',
> label = _('Quit')),
> - 'layerRaster' : MetaIcon(img = 'layer-raster-add',
> + 'layerRaster' : MetaIcon(img = 'raster',
> label = _('Add raster map layer')),
> - 'layerRgb' : MetaIcon(img = 'layer-rgb-add',
> + 'layerRgb' : MetaIcon(img = 'rgb',
> label = _('Add RGB map layer')),
> - 'layerHis' : MetaIcon(img = 'layer-his-add',
> + 'layerHis' : MetaIcon(img = 'his',
> label = _('Add HIS map layer')),
> - 'layerShaded' : MetaIcon(img = 'layer-shaded-relief-add',
> + 'layerShaded' : MetaIcon(img = 'shaded-relief',
> label = _('Add shaded relief map layer')),
> - 'layerRastarrow' : MetaIcon(img = 'layer-aspect-arrow-add',
> + 'layerRastarrow' : MetaIcon(img = 'aspect-arrow',
> label = _('Add raster flow arrows')),
> - 'layerRastnum' : MetaIcon(img = 'layer-cell-cats-add',
> + 'layerRastnum' : MetaIcon(img = 'cell-cats',
> label = _('Add raster cell numbers')),
> - 'layerVector' : MetaIcon(img = 'layer-vector-add',
> + 'layerVector' : MetaIcon(img = 'vector',
> label = _('Add vector map layer')),
> - 'layerThememap': MetaIcon(img = 'layer-vector-thematic-add',
> + 'layerThememap': MetaIcon(img = 'vector-thematic',
> label = _('Add thematic area (choropleth)
map layer')),
> - 'layerThemechart' : MetaIcon(img = 'layer-vector-chart-add',
> + 'layerThemechart' : MetaIcon(img = 'vector-chart',
> label = _('Add thematic chart layer')),
> 'layerGrid' : MetaIcon(img = 'layer-grid-add',
> label = _('Add grid layer')),
> @@ -94,12 +94,12 @@
> label = _('Add geodesic line layer')),
> 'layerRhumb' : MetaIcon(img = 'shortest-distance',
> label = _('Add rhumbline layer')),
> - 'layerLabels' : MetaIcon(img = 'layer-label-add',
> + 'layerLabels' : MetaIcon(img = 'label',
> label = _('Add labels')),
> - 'layer3d-raster' : MetaIcon(img = 'layer-raster3d-add',
> + 'layer3d-raster' : MetaIcon(img = 'raster3d',
> label = _('Add 3D raster map layer'),
> desc = _('Note that 3D raster data are
rendered only in 3D view mode')),
> - 'layerWms' : MetaIcon(img = 'layer-wms-add',
> + 'layerWms' : MetaIcon(img = 'wms',
> label = _('Add WMS layer.')),
> 'layerOptions' : MetaIcon(img = 'options',
> label = _('Set options')),
>
> _______________________________________________
> grass-commit mailing list
> grass-commit at lists.osgeo.org
> http://lists.osgeo.org/mailman/listinfo/grass-commit
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/grass-dev/attachments/20140719/a4eae302/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: lmgr-layer-icons-without-layer-and-add.png
Type: image/png
Size: 84594 bytes
Desc: not available
URL: <http://lists.osgeo.org/pipermail/grass-dev/attachments/20140719/a4eae302/attachment-0001.png>
More information about the grass-dev
mailing list