[GRASS-dev] [GRASS-SVN] r62770 - grass/trunk/lib/python/pygrass/raster/testsuite

[Vaclav Petras]

On Mon, Nov 17, 2014 at 8:05 AM, Markus Metz <markus.metz.giswork at gmail.com>
wrote:

> On Mon, Nov 17, 2014 at 1:05 PM, Markus Neteler <neteler at osgeo.org> wrote:
> > Hi Markus,
> >
> > please revert these changes: nc_spm is not used but nc_basic!
>
> No they run on full NS SPM. I want to add basic NC SPM but I need to do
some changes in top level run and report system. The PyGRASS tests were
written for basic NC, the rest for full NC, the issues is that they are
different.

The ultimate goal is to use the new sample location but it does not exist
yet. We've discussed with Helena and Hamish what Helena and MarkusN started
but there are still just the ideas.

http://lists.osgeo.org/pipermail/grass-dev/2014-September/070999.html
http://osgeo-org.1560.x6.nabble.com/Heading-towards-unified-dataset-td5165053.html


> ok, reverted in r62772
>
> You could have actually leave it there, it needs to be changed or
revisited anyway. But revert is fine too.


> According to the manual, tests are based on NC sample data [0], e.g.
>
> python -m grass.gunittest.main --location nc_spm_grass7 --location-type nc
>
> Sorry, but the examples in the manual are just examples. It is defined
nowhere so far which location is the right one or how often they should
run. You can run tests in whichever location you want and in fact I'm
running them in empty XY location and Piemonte UTM32 location. The issue
here is selecting tests which should run with which data, it needs just a
little bit more work to be functional (note: --location-type is currently
ignored).

See also "GSoC final report":

tests should specify the location they can run in
 * some code already exists for this but parsing of LOCATION variable or
tag needs to added
 * the missing piece is determination of which location types we need
(e.g., same maps but different projections)

Thanks for being involved in this, the ideal is that all developers would
run the tests (considering that we don't have common infrastructure to run
tests after each commit),
Vaclav

http://fatra.cnr.ncsu.edu/grassgistests/summary_report/index.html
http://grass.osgeo.org/grass71/manuals/libpython/gunittest_testing.html
http://grass.osgeo.org/grass71/manuals/libpython/gunittest_running_tests.html
http://trac.osgeo.org/grass/wiki/GSoC/2014/TestingFrameworkForGRASS#Finalreport


> Markus M
>
> [0]
> http://grass.osgeo.org/grass71/manuals/libpython/gunittest_testing.html
>
> > http://grass.osgeo.org/download/sample-data/
> > --> smaller subset NC location:
> >       --> GRASS 7 data subset tar.gz | zip (nc_basic...)
> >
> > Otherwise the online tests will be completely broken.
> >
> > markusN
> >
> >
> > On Mon, Nov 17, 2014 at 12:43 PM,  <svn_grass at osgeo.org> wrote:
> >> Author: mmetz
> >> Date: 2014-11-17 03:43:25 -0800 (Mon, 17 Nov 2014)
> >> New Revision: 62770
> >>
> >> Modified:
> >>    grass/trunk/lib/python/pygrass/raster/testsuite/test_category.py
> >>    grass/trunk/lib/python/pygrass/raster/testsuite/test_history.py
> >> Log:
> >> pygrass: testsuite raster geology does not exist in nc_spm
> >>
> >> Modified:
> grass/trunk/lib/python/pygrass/raster/testsuite/test_category.py
> >> ===================================================================
> >> --- grass/trunk/lib/python/pygrass/raster/testsuite/test_category.py
> 2014-11-17 11:34:40 UTC (rev 62769)
> >> +++ grass/trunk/lib/python/pygrass/raster/testsuite/test_category.py
> 2014-11-17 11:43:25 UTC (rev 62770)
> >> @@ -14,7 +14,7 @@
> >>
> >>  class RasterCategoryTestCate(TestCase):
> >>
> >> -    name = 'geology'
> >> +    name = 'geology_30m'
> >>      catsname = ''
> >>
> >>      def testCategory(self):
> >>
> >> Modified:
> grass/trunk/lib/python/pygrass/raster/testsuite/test_history.py
> >> ===================================================================
> >> --- grass/trunk/lib/python/pygrass/raster/testsuite/test_history.py
>  2014-11-17 11:34:40 UTC (rev 62769)
> >> +++ grass/trunk/lib/python/pygrass/raster/testsuite/test_history.py
>  2014-11-17 11:43:25 UTC (rev 62770)
> >> @@ -13,7 +13,7 @@
> >>
> >>  class RasterHistoryTestCate(TestCase):
> >>
> >> -    name = 'geology'
> >> +    name = 'geology_30m'
> >>
> >>      def testHistory(self):
> >>          r = RasterRow(self.name)
> >>
> >> _______________________________________________
> >> grass-commit mailing list
> >> grass-commit at lists.osgeo.org
> >> http://lists.osgeo.org/mailman/listinfo/grass-commit
> > _______________________________________________
> > grass-dev mailing list
> > grass-dev at lists.osgeo.org
> > http://lists.osgeo.org/mailman/listinfo/grass-dev
> _______________________________________________
> grass-dev mailing list
> grass-dev at lists.osgeo.org
> http://lists.osgeo.org/mailman/listinfo/grass-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/grass-dev/attachments/20141117/1348e1de/attachment.html>