[GRASS-dev] Return value from g.copy is one when --overwrite - bug or feature?

[Markus Neteler]

On Sun, Nov 8, 2015 at 11:22 AM, Rainer M Krug <Rainer at krugs.de> wrote:
> Huidae Cho <grass4u at gmail.com> writes:
>
>> Rainer,
>>
>> I cannot seem to replicate your issue:
>>
>> G srorg6630/tmp ~> g.version
>> GRASS 7.1.svn (2015)
>>
>> G srorg6630/tmp ~> g.list region
>> tmp
>> tmp.d.rast.edit.6753
>> tmp1
>>
>> G srorg6630/tmp ~> g.copy region=tmp,tmp1 --overwrite
>> Copy region definition <tmp at tmp> to current mapset as <tmp1>
>>
>> G srorg6630/tmp ~> echo $?
>> 0
>>
>> g.copy returns 1 when it cannot either read the source or write to the
>> target. Please check your permissions on your region files in
>> LOCATION/MAPSET/windows/.
>
> You are correct - they are read only.
>
> So the return value is correct - but an error should be raised - or is
> there a reason why this should silently fail?

It should probably not silently fail.

The code in question is in
lib/manage/do_copy.c

and potentially there to be added strerror(errno) as for example in
lib/gis/mapset_msc.c

?

Markus