[GRASS-dev] [GRASS-SVN] r66413 - grass-addons/grass7/vector/v.kriging

[Moritz Lennert]

On 05/10/15 16:49, Vaclav Petras wrote:
> On Mon, Oct 5, 2015 at 3:44 AM, Martin Landa <landa.martin at gmail.com
> <mailto:landa.martin at gmail.com>> wrote:
>  >
>  > Hi,
>  >
>  > 2015-10-05 9:41 GMT+02:00 Martin Landa <landa.martin at gmail.com
> <mailto:landa.martin at gmail.com>>:
>  > > compilation was simply failing on build server (Debian stable):
>
> It is working on Ubuntu and probably Fedora as well. Perhaps it is a
> local issue.
>
>  > >
>  > >> In file included from main.c:47:0:
>  > >> global.h:28:29: error: unknown type name ‘vec_struct’
>  > >> global.h:28:43: error: unknown type name ‘vec_struct’
>  > >> global.h:31:8: error: unknown type name ‘mat_struct’
>  > > ...
>  >
>  > even GRASS is compiled with lapack and blas support. I checked
> config.h again:
>  >
>  > /* define if LAPACK exists */
>  > #define HAVE_LIBLAPACK 1
>  >
>  > /* define if BLAS exists */
>  > #define HAVE_LIBBLAS 1
>
> Then la.h should be included in gmath.h. Including it in modules in a
> workaround, not the solution. There are three possible solutions:
>
> 1) remove la.h from gmath.h and declare that modules must include it (I
> don't see a reason for this)
>
> 2) change la.h include in gmath.h to something else; perhaps #if
> defined(...) && defined(...) is wrong (but I don't think so, seems to
> fit with the standard)
>
> 3) find out why it is different on that server and think about the
> proper fix afterwards (ideal)
>
> I can't test it since I can't reproduce it.
>
> Sorry for being -pedantic but I don't think we should leave the code messy.

+1