[GRASS-dev] r.fill.gaps porting

[Benjamin Ducke]

On 15/04/17 14:57, Markus Neteler wrote:
> 
> On Apr 15, 2017 2:52 PM, "Vaclav Petras" <wenzeslaus at gmail.com
> <mailto:wenzeslaus at gmail.com>> wrote:
>>
>> On Sat, Apr 15, 2017 at 8:03 AM, Markus Neteler <neteler at osgeo.org
> <mailto:neteler at osgeo.org>> wrote:
>> >
>> > > it is nice to see porting of old addons.
>> > > As you added an example with LiDAR data - it is too large. Reduce its
>> > > size as default module help tab is much more narrow.
>> >
>> > The HTML code currently is this:
>> >
>> > <img src="r_fill_gaps_01.png" alt="Raw data">  <img
> src="r_fill_gaps_02.png" alt="Gaps filled">
>>
>>
>> These are 250x232,
> 
> Would it be possible to have larger pics here? I guess they come from
> Benjamin?

No, the ones I submitted are really tiny.
The new LiDAR images are much larger. They
use the "width=" HMTL attribute, so they show
up much smaller on screen than they actually
are. Supposedly, the wxPython HTML renderer
does not apply "width=" correctly and does not
resize the image on the fly. However,
"Submitting/Docs" seems to assume that "width="
_will_ be processed correctly. So maybe the
best "fix" would be to add a statement to the
Wiki that images should be resized with an
external graphics editor (to 600 pixels width
or less) before including them in HTML man pages.

Cheers,

Ben

> 
>> so I assume you mean r_fill_gaps_lidar.png.
>>
>> > Please use the img code as per submitting docs style guide in trac.
>>
>> The current code is:
>>
>> <a href="r_fill_gaps_lidar.png">
>> <img src="r_fill_gaps_lidar.png" alt="Point density and ground
> surface" width=600>
>> </a>
>>
>> which is almost exactly the following from Submitting/Docs [1]:
> 
> Ah I see... I'm mostly on mobile currently due to traveling, hence no
> easy reading of commit msgs.
> 
>> <a href="r_viewshed.png">
>> <img src="r_viewshed.png" width="600" alt="r.viewshed example" border=0>
>> </a>
>>
>> The submitting guide does not consider the wxPython GUI manual tab
> which doesn't understand more advanced HTML correctly. Please advise on
> the next steps.
> 
> Ok just ignore my comment :)
> 
> Markus
> 
>> Vaclav
>>
>> [1] https://trac.osgeo.org/grass/wiki/Submitting/Docs
> 
> 
> 
> _______________________________________________
> grass-dev mailing list
> grass-dev at lists.osgeo.org
> https://lists.osgeo.org/mailman/listinfo/grass-dev
> 



-- 
Dr. Benjamin Ducke
{*} Geospatial Consultant
{*} GIS Developer

Spatial technology for the masses, not the classes:
experience free and open source GIS at http://gvsigce.org