[GRASS-dev] [GRASS GIS] #3469: i.atcorr: Sentinel-2 support broken on some systems

[GRASS GIS]

#3469: i.atcorr: Sentinel-2 support broken on some systems
--------------------------+-------------------------
  Reporter:  sbl          |      Owner:  grass-dev@…
      Type:  defect       |     Status:  new
  Priority:  normal       |  Milestone:  7.4.0
 Component:  Packaging    |    Version:  unspecified
Resolution:               |   Keywords:  i.atcorr
       CPU:  Unspecified  |   Platform:  Unspecified
--------------------------+-------------------------

Comment (by mmetz):

 Replying to [comment:15 mlennert]:
 > Replying to [comment:12 sbl]:
 > > Yes, thanks so much Markus!
 > > With the patch i.atcorr gives now also numbers on Ubuntu 14.04:
 > >
 > > {{{
 > > min = 0  max = 8514
 > > }}}
 > > So results are identical to Moritz`s.
 > >
 > > I noticed that although "rescale" option was set to be 0-10000,
 maximum output was 8514...\\
 >
 > This depends on your input data and your range parameter:
 >
 > {{{
 > r.info -r B08
 > min=83
 > max=7110
 >
 > i.atcorr -r input=B08 elevation=dem range=83,7110 output=test_atcorr
 rescale=0,10000 parameters=BROL/STEFAN/p6s.txt --v --o
 >
 > r.info -r test_atcorr
 > min=8.732422e-10
 > max=10000
 > }}}
 >
 > i.e. if you tell it to scale the input data range to 0,10000 it will do
 so, but if you tell it that the input range is 1,10000 then it will scale
 this range to 0,10000.
 >
 > Markus, could it be that you are using the original larger input image
 from the ML and not the smaller clip attached to this ticket ?

 Yes, right. Now with the smaller clip using the command in the description
 of this ticket
 {{{
 i.atcorr -r input=B08 elevation=dem range=0,10000 output=test_atcorr
 rescale=0,10000 parameters=p6s.txt --v --o
 }}}

 I get
 {{{
 min=0.04157807
 max=8513.816
 }}}

 you get
 {{{
 min=0.3878489
 max=8513.962
 }}}


 i.atcorr rescales the input to 0,1 using the range option, then does the
 transformation and rescales the result from 0,1 to the rescale option.

 Be aware that if you don't specify range and rescale, default 0,255 will
 be used which will produce strange results if the input range is much
 larger than 0,255. Conversely, if the actual input range is smaller than
 provided with the range option, the output will also be only a subset of
 the rescale range.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3469#comment:17>
GRASS GIS <https://grass.osgeo.org>