[GRASS-dev] r.in.pdal

[Markus Metz]

2018-08-06 12:12 GMT+02:00 Anika Bettge <bettge at mundialis.de>:
>
> Hi all,
>
> I just uploaded my first GRASS GIS addon r.in.pdal:
>
> https://trac.osgeo.org/grass/browser/grass-addons/grass7/raster/r.in.pdal.

Thanks a lot to your contribution Anika!

A few cosmetic suggestions:

the print command in L268 should be replaced with grass.message because
this is not shell-style output
L353:
        grass.message(_("Generating output raster map <%s>...") % outfile)
seems to be at the wrong place because nothing happens after that message
same for L191

you can you set the metadata on the resultant output raster with r.support,
otherwise metadata will be set by r.in.xyz (the module that actually
created the raster)

there are some comments on gdalwarp, but gdalwarp is not used by r.in.pdal

Best,

Markus M

>
>
> Best regards,
> Anika
>
> --
>
>   Anika Bettge
>   - Anwendungsentwicklerin -
>
>   mundialis GmbH & Co. KG
>   Kölnstraße 99
>   53111 Bonn
>
>   Tel: +49 (0)228 / 38 75 80 -80
>   Fax: +49 (0)228 / 96 28 99 -57
>
>   Email: bettge at mundialis.de
>   Web: https://www.mundialis.de
>
>   Amtsgericht Bonn, HRA 8528
>   Komplementärin: mundialis Verwaltungsgesellschaft mbH
>   vertreten durch: Dr. Markus Neteler, Hinrich Paulsen, Till Adams
>
>   Informationen über Ihre gespeicherten Daten finden Sie auf unserer
Homepage unter folgendem Link:
>   https://www.mundialis.de/datenschutzerklaerung
>
> _______________________________________________
> grass-dev mailing list
> grass-dev at lists.osgeo.org
> https://lists.osgeo.org/mailman/listinfo/grass-dev
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/grass-dev/attachments/20180806/0eae24f2/attachment.html>