[GRASS-dev] [GRASS GIS] #3537: Add functionalities –tmp-location and –no-clean

[GRASS GIS]

#3537: Add functionalities –tmp-location and –no-clean
-----------------------------+------------------------------------------
  Reporter:  radeknovotny94  |      Owner:  grass-dev@…
      Type:  enhancement     |     Status:  new
  Priority:  normal          |  Milestone:  7.6.0
 Component:  Startup         |    Version:  svn-trunk
Resolution:                  |   Keywords:  tmp-location, no-clean, exec
       CPU:  All             |   Platform:  All
-----------------------------+------------------------------------------

Comment (by wenzeslaus):

 Thank you for submitting a new version. Perhaps next time, leave there the
 old diff file, so we can refer to it if needed. About the diff itself:

 1. I didn't catch it the first time, but it seems there was
 misunderstanding about what `--no-clean` should do. See the
 [wiki:GSoC/2018#Neweasy-to-useCLIandAPIforGRASSGIS wiki] again, ''...if
 --exec should clean the .tmp directory in the Mapset.'' This relates to
 the `clean_temp()` function (it is not connected to the `Cleaner` class,
 the code is only partially re-factored and this is really something
 different anyway). The description at the wiki says ''for parallel
 execution''. Try to run two (longer running) processes in parallel, at
 least sometimes, one will fail because the other deleted its temporary
 files in the Mapset .tmp directory. Let us know if you need more
 explanation on this, perhaps directly on the mailing list, so that more
 people can answer. I'm not sure at this point if your `--no-clean` is
 useful for something or not. Did you have any use case?

 2. Please provide documentation for this, ideally as part of the
 `grass7.html` file. This will make testing easier and addressing the use
 cases.

 3. It would be great of you come up with some more formal tests for it. It
 does not really fit into the `gunittest` tests but we can always start
 with a Bash script executing series of commands.

 4. Any particular reason to place `--no-clean` on the same line with
 `[[[GISDBASE/]LOCATION_NAME/]MAPSET]` in the help message? It should be
 probably with `--exec` or close to `-f`.

 5. In generally, please avoid unrelated whitespace changes in the
 patches/commits. Whitespace and other PEP8 things can and should be
 changed, but in separate commits. See your lines 375 and 403 (Trac view
 numbering) in your diff.

-- 
Ticket URL: <https://trac.osgeo.org/grass/ticket/3537#comment:4>
GRASS GIS <https://grass.osgeo.org>