[GRASS-dev] [GRASS GIS] #3635: Suspicious use and cleanup of the mapset tempoary directory

[GRASS GIS]

#3635: Suspicious use and cleanup of the mapset tempoary directory
-------------------------+-------------------------------------------------
  Reporter:  wenzeslaus  |      Owner:  wenzeslaus
      Type:  defect      |     Status:  new
  Priority:  normal      |  Milestone:  7.6.0
 Component:  Startup     |    Version:  svn-trunk
Resolution:              |   Keywords:  init grass.py clean_temp .tmp temp
       CPU:              |  g.mapset wxGUI rendering
  Unspecified            |   Platform:  All
-------------------------+-------------------------------------------------
Changes (by wenzeslaus):

 * owner:  grass-dev@… => wenzeslaus


Comment:

 The commit message for r54467 does not specify why the change - addition
 of `os.path.join(location, ".tmp")` - was needed and what is its relation
 to `clean_temp`. (Note that "location" means full path to mapset; same
 below.)

 Similar line is `cleanup_dir(os.path.join(location, ".tmp"))` with comment
 "remove GUI session files from .tmp" which is called on MS Windows for GUI
 startup suggests some cleaning after GUI. However, it comes from the
 original translation of the startup script to Python (r37863). It
 originated from r21048 which was working around some bug related to
 !Tcl/Tk GUI.

 If GUI works as expected after #3637, the GUI files should disappear from
 the mapset tmp dir because all will be in the system tmp dir, then the
 line from r37863 won't be needed if its comment refers to rendered files.

 As for r54467, I don't see why `clean_temp` is not enough. So, unless I
 find something, e.g. that `clean_temp` is broken or somebody suggests why
 it is there, I'm going to remove this clean up and let `grass.py` rely on
 `clean_temp`.

 ''Preferred milestone: 7.8 (not in Trac yet)''

-- 
Ticket URL: <https://trac.osgeo.org/grass/ticket/3635#comment:1>
GRASS GIS <https://grass.osgeo.org>