[GRASS-dev] Contributing to addons on GitHub

[Brendan]

Thanks. Got it.

Documentation with old instructions includes:

How to Contribute
https://trac.osgeo.org/grass/wiki/HowToContribute#SettingupthenewSVNwriteaccessafteracceptance

Submitting
https://trac.osgeo.org/grass/wiki/Submitting#GRASSGISAddons
https://trac.osgeo.org/grass/wiki/Submitting#SubmittingcodetoSVN

How to SVN
https://trac.osgeo.org/grass/wiki/HowToSVN

The GitHub GRASS Addons repo contains SVN_HOWTO.txt
<https://github.com/OSGeo/grass-addons/blob/master/SVN_HOWTO.txt>
rather than a git HOWTO like https://trac.osgeo.org/grass/wiki/HowToGit
I think a link in the README to https://trac.osgeo.org/grass/wiki/HowToGit
would help.

Submitting Python Code
https://trac.osgeo.org/grass/wiki/Submitting/Python
mentions svn diff which could be updated to git diff
I believe there was a discussion on the grass-dev list about using Python
Black for style.
Was there a decision? That could be added to this wiki page.

-Brendan

On Mon, Dec 30, 2019 at 3:04 PM Markus Neteler <neteler at osgeo.org> wrote:

> Hi,
>
> Brendan <brendan.harmon at gmail.com> schrieb am Mo., 30. Dez. 2019, 21:27:
>
>> With the migration to GitHub, what exactly is the process for making
>> contributions to the addons repository?
>>
>
> Please fork, edit/add and make pull requests.
>
> Some of the documentation still covers SVN rather than git.
>>
>
> Ok that should be updated accordingly.
> Which docs do you refer to?
>
> Can I directly pull, commit, and push from master or should I make a
>> branch and then submit a pull request?
>>
>
> A PR is the preferred way.
> If it is your own code you can also merge right away. If it is other
> author's code, some feedback might be fair to be obtained (via PR) but it
> also depends a bit on the case.
>
> HTH, my 0.02 cents,
>
> Markus
>
>
> Thanks, Brendan
>> _______________________________________________
>> grass-dev mailing list
>> grass-dev at lists.osgeo.org
>> https://lists.osgeo.org/mailman/listinfo/grass-dev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/grass-dev/attachments/20191230/17d6e564/attachment.html>