[GRASS-dev] GitHub: how to fwd pull requests to this list?

Huidae Cho grass4u at gmail.com
Mon Jul 15 09:07:34 PDT 2019


Hi,

The oldest PR is 2 months old. Using git for collaboration is very
different from svn, I believe. Unlike with svn, you have to "actively"
merge these PRs into your branch for testing (e.g., features interesting to
you?) and wait for an approval from reviewers (?). Why did it not happen to
these old PRs? Now, a less bigger question is no one cares about them and
who is supposed to be responsible for reviewing and approving them?

For example, https://github.com/OSGeo/grass/pull/52 fixes a very obvious
formatting issue, which still needs to be approved? Tried to approve it
myself, but self-nominating myself as a reviewer is pending... Hmm... Can I
even merge it? The merge button seems to be activated. Confused...

Best,
Huidae

On Mon, Jul 15, 2019 at 6:53 AM Markus Neteler <neteler at osgeo.org> wrote:

> Hi
>
> Anna Petrášová <kratochanna at gmail.com> schrieb am Mo., 15. Juli 2019,
> 05:57:
>
>>
>>
>> On Fri, Jul 12, 2019 at 12:50 PM Maris Nartiss <maris.gis at gmail.com>
>> wrote:
>>
>>> The biggest question is – do we need PR notifications here. I would
>>> vote for no. Better let's keep discussions in one place.
>>>
>>
>> I agree, and I get the notifications:
>> https://help.github.com/en/articles/watching-and-unwatching-repositories
>>
>
>
> Then please all promise to subscribe to the repo notifications and look at
> them :)
>
> Thanks
> Markus
>
> PS: with "lost" I meant that nobody cares/d. Perhaps since many didn't
> subscribe to notifications yet...
>
>>
>>>

-- 
Huidae Cho, Ph.D., GISP, PE (MD), CFM, M.ASCE
Open Source GIS Developer, GRASS GIS Development Team
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/grass-dev/attachments/20190715/4316e722/attachment.html>


More information about the grass-dev mailing list