[GRASS-dev] [GRASS GIS] #3779: quadruplicated definition of "do_doctest_gettext_workaround()"

GRASS GIS trac at osgeo.org
Wed Mar 6 10:21:41 PST 2019


#3779: quadruplicated definition of "do_doctest_gettext_workaround()"
-------------------------+-------------------------
 Reporter:  pmav99       |      Owner:  grass-dev@…
     Type:  defect       |     Status:  new
 Priority:  normal       |  Milestone:
Component:  Tests        |    Version:  svn-trunk
 Keywords:               |        CPU:  Unspecified
 Platform:  Unspecified  |
-------------------------+-------------------------
 {{{do_doctest_gettext_workaround()}}} is being defined 4 times in the
 codebase.

 AFAI can tell, apart from the {{{docstrings}}} there are no differences
 whatsoever.
 {{{
 $  ag 'def do_doctest'
 gui/wxpython/tools/build_modules_xml.py
 33:def do_doctest_gettext_workaround():

 gui/wxpython/core/utils.py
 1155:def do_doctest_gettext_workaround():

 gui/wxpython/core/toolboxes.py
 774:def do_doctest_gettext_workaround():

 lib/python/gunittest/utils.py
 35:def do_doctest_gettext_workaround():
 }}}

 {{{lib/python/gunittest/utils.py}}} seems like the most reasonable place
 to keep this definition. The other definitions should be removed and the
 imports in the gui library should be updated. The docstring at
 {{{gui/wxpython/core/toolboxes.py}}} is the most informative one.

-- 
Ticket URL: <https://trac.osgeo.org/grass/ticket/3779>
GRASS GIS <https://grass.osgeo.org>



More information about the grass-dev mailing list