[GRASS-dev] best practices for subject lines of PR

Markus Neteler neteler at osgeo.org
Wed May 20 05:50:09 PDT 2020


Hi,

On Sat, May 16, 2020 at 2:19 PM Moritz Lennert
<mlennert at club.worldonline.be> wrote:
> On 16/05/20 03:32, Vaclav Petras wrote:
> > On Fri, May 8, 2020 at 1:04 PM Stefan Blumentrath
> > <Stefan.Blumentrath at nina.no <mailto:Stefan.Blumentrath at nina.no>> wrote:
> >
> >     Hi,
> >
> >     Yes, I would also be very interested in some guidance on this!
> >
> > Here are guidelines I wrote for commit messages for Subversion. A lot of
> > it should still apply for both commits and PRs.
> >
> > https://trac.osgeo.org/grass/wiki/Submitting/General#Commitmessages
>
> That is a useful general guide, but the recent discussion was concerning
> labelling commits specifically for making it easier to decide which ones
> should be part of release news. I don't know if these guidelines are
> enough for that, or whether we should decide on specific tags (either
> github tags or [XYZ] tags in the commit message. Maybe MarkusN can give
> us his opinion as he has the experience of extracting the info.

Well, for me the labelling is less important than simply useful commit
title messages.
The "Good examples" in the trac page above do 80+% of the job.
As I am closely following the development I usually know what's relevant.
And: others may edit as well :-) - in case their favourite
bugfix/enhancement isn't listed.

Best
Markus


More information about the grass-dev mailing list