[GRASS-dev] C code indented

Wolf Bergenheim wolf+grass at bergenheim.net
Sat Sep 17 01:57:45 PDT 2022


On Tue, 13 Sept 2022 at 09:33, Vaclav Petras <wenzeslaus at gmail.com> wrote:

>
> Formatting needs to be enforced in the CI. This can be done with something
> like re-indent followed by git diff.
>
>
Maybe something like this could be used?
https://github.com/marketplace/actions/clang-format-check  Note that it
doesn't actually format the code, but would complain like the current black
formatter for python 🤔

or perhaps https://github.com/material-foundation/clang-format-ci seems to
do the same, and leaves inline comments

--Wolf

Best,
> Vaclav
>
> On Sat, 27 Aug 2022 at 14:06, Vaclav Petras <wenzeslaus at gmail.com> wrote:
>
>> Dear all,
>>
>> Most of the C and C++ code was indented using our
>> ./utils/grass_indent_ALL.sh script at the FOSS4G 2022 sprint. This will
>> help to indent code for PRs and with the transition to clang-format.
>>
>> Directories with files which indent reports issues for were not updated,
>> because more changes are needed in the code.
>>
>> This may create conflicts in some existing PR which modify C code. If you
>> have a conflict related to this (old PR may have other conflicts too), you
>> can follow this procedure:
>>
>> Indent your code:
>>
>> ./utils/grass_indent.sh db/drivers/mysql/create_table.c
>>
>> Commit the change:
>>
>> git commit -m "Indent PR code" db/drivers/mysql/create_table.c
>>
>> Update upstream/main branch:
>>
>> git fetch upstream
>>
>> Merge into your branch upstream/main:
>>
>> git merge --strategy=recursive --strategy-option=ours upstream/main
>>
>> Let me know if you have any questions,
>> Vaclav
>>
> _______________________________________________
> grass-dev mailing list
> grass-dev at lists.osgeo.org
> https://lists.osgeo.org/mailman/listinfo/grass-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/grass-dev/attachments/20220917/d93d87d3/attachment.htm>


More information about the grass-dev mailing list