SOCCER LAB GRASS QA: 4 clones ( main.c main.c main.c ) 3 monsters and 6 warnings

[cvs at proxy.soccerlab.polymtl.ca]

Hello cho,

here a report on your recent GRASS-CVS change:

Threshold GRASS6 key metrics values at 2006-04-04 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      36 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:               9 |        55 |      78 |
LOC:                    40 |       182 |     254 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function

ANALYSIS

your changes to files/functions:


./grass6/raster/r.in.arc/main.c functions


main (Begins at: 14 Ends at: 195)
--------------+---------+-------+---------+
Complexity:   |      31 |    ** | Warning |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |      69 |    ** | Warning |
LOC:          |     182 |     * |         |
--------------+---------+-------+---------+
at least 3 values are close to an outlier please consider revising code

file_cpy (Begins at: 198 Ends at: 224)
--------------+---------+-------+---------+
Complexity:   |       5 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       5 |       |      OK |
LOC:          |      27 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file has 1 potentially cloned functions:
  file_cpy

__________________________________________

Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html