SOCCER LAB GRASS QA: 3 clones ( main.c main.c ) 3 monsters and 3 warnings

[cvs at proxy.soccerlab.polymtl.ca]

Hello cho,

here a report on your recent GRASS-CVS change:

Threshold GRASS6 key metrics values at 2006-04-04 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      36 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:               9 |        55 |      78 |
LOC:                    40 |       182 |     254 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function

ANALYSIS

your changes to files/functions:


./grass6/raster3d/r3.out.vtk/main.c functions


fatalError (Begins at: 62 Ends at: 79)
--------------+---------+-------+---------+
Complexity:   |       5 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       6 |       |      OK |
LOC:          |      18 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

setParams (Begins at: 85 Ends at: 193)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       0 |       |      OK |
CalledNBR:    |      26 |       |      OK |
LOC:          |     109 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

OpenInputMap (Begins at: 199 Ends at: 214)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       4 |       |      OK |
LOC:          |      16 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

CloseInputMap (Begins at: 220 Ends at: 226)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       3 |       |      OK |
LOC:          |       7 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

CheckInputMaps (Begins at: 232 Ends at: 307)
--------------+---------+-------+---------+
Complexity:   |      14 |       |      OK |
ParamNBR:     |       0 |       |      OK |
CalledNBR:    |      23 |       |      OK |
LOC:          |      76 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

OpenWriteRGBMaps (Begins at: 313 Ends at: 382)
--------------+---------+-------+---------+
Complexity:   |      16 |     * |         |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |      18 |       |      OK |
LOC:          |      70 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

OpenWriteVectorMaps (Begins at: 387 Ends at: 457)
--------------+---------+-------+---------+
Complexity:   |      16 |     * |         |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |      18 |       |      OK |
LOC:          |      71 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

writeVTKStructuredPointHeader (Begins at: 463 Ends at: 517)
--------------+---------+-------+---------+
Complexity:   |       6 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |      16 |       |      OK |
LOC:          |      55 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

writeVTKStructuredGridHeader (Begins at: 523 Ends at: 538)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       8 |       |      OK |
LOC:          |      16 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

writeVTKPoints (Begins at: 544 Ends at: 651)
--------------+---------+-------+---------+
Complexity:   |      15 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |      26 |       |      OK |
LOC:          |     108 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

writeVTKData (Begins at: 657 Ends at: 731)
--------------+---------+-------+---------+
Complexity:   |       8 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |      25 |       |      OK |
LOC:          |      75 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

writeVTKRGBVoxelData (Begins at: 737 Ends at: 876)
--------------+---------+-------+---------+
Complexity:   |      18 |     * |         |
ParamNBR:     |       7 |    ** | Warning |
CalledNBR:    |      36 |     * |         |
LOC:          |     140 |     * |         |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

writeVTKVectorData (Begins at: 882 Ends at: 985)
--------------+---------+-------+---------+
Complexity:   |      14 |       |      OK |
ParamNBR:     |       7 |    ** | Warning |
CalledNBR:    |      24 |       |      OK |
LOC:          |     104 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

main (Begins at: 990 Ends at: 1150)
--------------+---------+-------+---------+
Complexity:   |      20 |     * |         |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |      55 |     * |         |
LOC:          |     161 |     * |         |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

Clone analysis:

This file has 1 potentially cloned functions:
  OpenInputMap

__________________________________________

Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html