SOCCER LAB GRASS QA: 2 clones ( main.c ) 3 monsters and 0 warnings

[cvs at proxy.soccerlab.polymtl.ca]

Hello cho,

here a report on your recent GRASS-CVS change:

Threshold GRASS6 key metrics values at 2006-04-04 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      36 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:               9 |        55 |      78 |
LOC:                    40 |       182 |     254 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function

ANALYSIS

your changes to files/functions:


./grass6/raster3d/r3.out.ascii/main.c functions


fatalError (Begins at: 53 Ends at: 64)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       3 |       |      OK |
LOC:          |      12 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

setParams (Begins at: 70 Ends at: 110)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       0 |       |      OK |
CalledNBR:    |      12 |       |      OK |
LOC:          |      41 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

getParams (Begins at: 116 Ends at: 121)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |       6 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

writeHeaderString (Begins at: 128 Ends at: 135)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       3 |       |      OK |
LOC:          |       8 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

writeHeaderString2 (Begins at: 139 Ends at: 146)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       3 |       |      OK |
LOC:          |       8 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

openAscii (Begins at: 153 Ends at: 184)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |      13 |       |      OK |
LOC:          |      32 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G3dToascii (Begins at: 191 Ends at: 240)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       9 |       |      OK |
LOC:          |      50 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

main (Begins at: 247 Ends at: 325)
--------------+---------+-------+---------+
Complexity:   |      13 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |      27 |       |      OK |
LOC:          |      79 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file has 2 potentially cloned functions:
  writeHeaderString2  writeHeaderString

__________________________________________

Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html