SOCCER LAB GRASS QA: no clones 3 monsters and 1 warnings

[cvs at proxy.soccerlab.polymtl.ca]

Hello markus,

here a report on your recent GRASS-CVS change:

Threshold GRASS6 key metrics values at 2006-04-04 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      36 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:               9 |        55 |      78 |
LOC:                    40 |       182 |     254 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function

ANALYSIS

your changes to files/functions:


./grass6/vector/v.patch/main.c functions


main (Begins at: 43 Ends at: 365)
--------------+---------+-------+---------+
Complexity:   |      37 |   *** | MONSTER |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |      99 |   *** | MONSTER |
LOC:          |     323 |   *** | MONSTER |
--------------+---------+-------+---------+
3 metric are OUT OF RANGE!

copy_records (Begins at: 368 Ends at: 462)
--------------+---------+-------+---------+
Complexity:   |      16 |     * |         |
ParamNBR:     |       6 |     * |         |
CalledNBR:    |      42 |     * |         |
LOC:          |      95 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

patch (Begins at: 464 Ends at: 503)
--------------+---------+-------+---------+
Complexity:   |       5 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       6 |       |      OK |
LOC:          |      40 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

max_cat (Begins at: 505 Ends at: 524)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |      20 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file does not contain  cloned functions

__________________________________________

Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html