SOCCER LAB GRASS QA: 1 clones ( main.c ) 2 monsters and 2 warnings

[cvs at proxy.soccerlab.polymtl.ca]

Hello hamish,

here a report on your recent GRASS-CVS change:

Threshold GRASS6 key metrics values at 2006-04-06 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      36 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:               9 |        55 |      78 |
LOC:                    40 |       182 |     254 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function

ANALYSIS

your changes to files/functions:


./grass6/display/d.nviz/main.c functions


main (Begins at: 43 Ends at: 395)
--------------+---------+-------+---------+
Complexity:   |      26 |    ** | Warning |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |     156 |   *** | MONSTER |
LOC:          |     353 |   *** | MONSTER |
--------------+---------+-------+---------+
2 metric are OUT OF RANGE!

do_profile (Begins at: 402 Ends at: 471)
--------------+---------+-------+---------+
Complexity:   |      10 |       |      OK |
ParamNBR:     |       7 |    ** | Warning |
CalledNBR:    |      29 |       |      OK |
LOC:          |      70 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

move (Begins at: 474 Ends at: 479)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |       6 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

cont (Begins at: 481 Ends at: 502)
--------------+---------+-------+---------+
Complexity:   |       5 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |      22 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

read_rast (Begins at: 509 Ends at: 612)
--------------+---------+-------+---------+
Complexity:   |      15 |       |      OK |
ParamNBR:     |       6 |     * |         |
CalledNBR:    |      24 |       |      OK |
LOC:          |     104 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

Clone analysis:

This file has 1 potentially cloned functions:
  cont

__________________________________________

Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html