[GRASS-QA] GRASS QA: soeren | ./grass6/raster/r.out.vtk/writeascii.c |1 clones ( writeascii.c )| 0 monsters | 4 warnings

grass-qa at proxy.soccerlab.polymtl.ca grass-qa at proxy.soccerlab.polymtl.ca
Mon Aug 14 14:23:49 EDT 2006



Hello soeren,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


raster/r.out.vtk/writeascii.c functions


get_raster_value_as_double (Begins at: 34 Ends at: 64)
--------------+---------+-------+---------+
Complexity:   |       7 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       3 |       |      OK |
LOC:          |      31 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

write_vtk_normal_header (Begins at: 70 Ends at: 96)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |      11 |       |      OK |
LOC:          |      27 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

write_vtk_structured_elevation_header (Begins at: 102 Ends at: 113)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       8 |       |      OK |
LOC:          |      12 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

write_vtk_polygonal_elevation_header (Begins at: 118 Ends at: 128)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       7 |       |      OK |
LOC:          |      11 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

write_vtk_celldata_header (Begins at: 133 Ends at: 137)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       3 |       |      OK |
LOC:          |       5 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

write_vtk_pointdata_header (Begins at: 142 Ends at: 146)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       3 |       |      OK |
LOC:          |       5 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

write_vtk_structured_coordinates (Begins at: 153 Ends at: 201)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       7 |    ** | Warning |
CalledNBR:    |      13 |       |      OK |
LOC:          |      49 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

write_vtk_polygonal_coordinates (Begins at: 207 Ends at: 314)
--------------+---------+-------+---------+
Complexity:   |       6 |       |      OK |
ParamNBR:     |       8 |    ** | Warning |
CalledNBR:    |      23 |       |      OK |
LOC:          |     108 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

write_vtk_data (Begins at: 320 Ends at: 362)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       6 |     * |         |
CalledNBR:    |      16 |       |      OK |
LOC:          |      43 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

write_vtk_rgb_image_data (Begins at: 370 Ends at: 429)
--------------+---------+-------+---------+
Complexity:   |       5 |       |      OK |
ParamNBR:     |       7 |    ** | Warning |
CalledNBR:    |      29 |       |      OK |
LOC:          |      60 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

write_vtk_vector_data (Begins at: 436 Ends at: 487)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       7 |    ** | Warning |
CalledNBR:    |      26 |       |      OK |
LOC:          |      52 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

Clone analysis:

This file has 1 potentially cloned functions:
  GetRasterValueAsDouble

In raster/r.out.vtk/writeascii.c clones of  GetRasterValueAsDouble are:
	raster3d/r3.out.vtk/writeVTKData.c  GetRasterValueAsDouble


__________________________________________

Threshold GRASS6 key metrics values at 2006-08-14 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      36 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:               9 |        55 |      80 |
LOC:                    39 |       179 |     251 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html




More information about the grass-qa mailing list