[GRASS-QA] GRASS QA: markus | ./grass6/raster/r.null/null.c |1 clones ( main.c main.c main.c parser.c main.c main.c main.c main.c main.c main.c main.c null.c )| 0 monsters | 2 warnings

[grass-qa at proxy.soccerlab.polymtl.ca]

Hello markus,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


raster/r.null/null.c functions


main (Begins at: 13 Ends at: 214)
--------------+---------+-------+---------+
Complexity:   |      16 |     * |         |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |      65 |    ** | Warning |
LOC:          |     202 |    ** | Warning |
--------------+---------+-------+---------+
at least 2 values are close to an outlier please consider revising code

parse_vallist (Begins at: 216 Ends at: 249)
--------------+---------+-------+---------+
Complexity:   |       6 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |      10 |       |      OK |
LOC:          |      34 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

parse_d_mask_rule (Begins at: 252 Ends at: 285)
--------------+---------+-------+---------+
Complexity:   |       6 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |      13 |       |      OK |
LOC:          |      34 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

process (Begins at: 288 Ends at: 330)
--------------+---------+-------+---------+
Complexity:   |       7 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |      15 |       |      OK |
LOC:          |      43 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

doit (Begins at: 333 Ends at: 392)
--------------+---------+-------+---------+
Complexity:   |       6 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |      25 |       |      OK |
LOC:          |      60 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file has 1 potentially cloned functions:
  parse_vallist

In raster/r.null/null.c clones of  parse_vallist are:
	display/d.rast/main.c  parse_vallist
	display/d.rast/main.c  parse_catlist


__________________________________________

Threshold GRASS6 key metrics values at 2006-08-19 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      36 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:               9 |        55 |      80 |
LOC:                    39 |       179 |     251 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html