[GRASS-QA] GRASS QA: markus | ./grass6/vector/v.net.steiner/main.c |1 clones ( main.c main.c main.c parser.c main.c main.c main.c main.c main.c main.c main.c null.c main.c main.c main.c main.c main.c main.c main.c main.c main.c main.c )| 3 monsters | 0 warnings

[grass-qa at proxy.soccerlab.polymtl.ca]

Hello markus,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


vector/v.net.steiner/main.c functions


init_node_costs (Begins at: 51 Ends at: 74)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       3 |       |      OK |
LOC:          |      24 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

get_node_costs (Begins at: 80 Ends at: 105)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |      26 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

mst (Begins at: 107 Ends at: 293)
--------------+---------+-------+---------+
Complexity:   |      19 |     * |         |
ParamNBR:     |       9 |   *** | MONSTER |
CalledNBR:    |      27 |       |      OK |
LOC:          |     187 |    ** | Warning |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!

main (Begins at: 295 Ends at: 580)
--------------+---------+-------+---------+
Complexity:   |      20 |     * |         |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |     102 |   *** | MONSTER |
LOC:          |     286 |   *** | MONSTER |
--------------+---------+-------+---------+
2 metric are OUT OF RANGE!

cmp (Begins at: 582 Ends at: 594)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |      13 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file has 1 potentially cloned functions:
  cmp

In vector/v.net.steiner/main.c clones of  cmp are:
	vector/v.net.salesman/main.c  cmp


__________________________________________

Threshold GRASS6 key metrics values at 2006-08-19 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      36 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:               9 |        55 |      80 |
LOC:                    39 |       179 |     251 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html