[GRASS-QA] GRASS QA: markus |
./grass6/vector/lidar/lidarlib/InterpSpline.c |2 clones (
InterpSpline.c )| 6 monsters | 0 warnings
grass-qa at proxy.soccerlab.polymtl.ca
grass-qa at proxy.soccerlab.polymtl.ca
Tue Aug 22 16:26:04 EDT 2006
Hello markus,
here a report on your recent GRASS-CVS change:
ANALYSIS
your changes to files/functions:
vector/lidar/lidarlib/InterpSpline.c functions
node_x (Begins at: 12 Ends at: 18)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 5 | * | |
CalledNBR: | 0 | | OK |
LOC: | 7 | | OK |
--------------+---------+-------+---------+
metrics are OK
node_y (Begins at: 23 Ends at: 29)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 5 | * | |
CalledNBR: | 0 | | OK |
LOC: | 7 | | OK |
--------------+---------+-------+---------+
metrics are OK
order (Begins at: 34 Ends at: 37)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
phi_3 (Begins at: 42 Ends at: 45)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
phi_4 (Begins at: 47 Ends at: 50)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
phi_33 (Begins at: 52 Ends at: 55)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
phi_34 (Begins at: 57 Ends at: 60)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
phi_43 (Begins at: 62 Ends at: 65)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
phi_44 (Begins at: 67 Ends at: 70)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
phi (Begins at: 72 Ends at: 75)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 4 | | OK |
--------------+---------+-------+---------+
metrics are OK
normalDefBicubic (Begins at: 80 Ends at: 156)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 13 | *** | MONSTER |
CalledNBR: | 22 | | OK |
LOC: | 77 | | OK |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!
nCorrectLapl (Begins at: 162 Ends at: 235)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 6 | * | |
CalledNBR: | 3 | | OK |
LOC: | 74 | | OK |
--------------+---------+-------+---------+
metrics are OK
normalDefBilin (Begins at: 240 Ends at: 336)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 13 | *** | MONSTER |
CalledNBR: | 10 | | OK |
LOC: | 97 | | OK |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!
nCorrectGrad (Begins at: 338 Ends at: 366)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 6 | * | |
CalledNBR: | 0 | | OK |
LOC: | 29 | | OK |
--------------+---------+-------+---------+
metrics are OK
obsEstimateBicubic (Begins at: 371 Ends at: 425)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 10 | *** | MONSTER |
CalledNBR: | 19 | | OK |
LOC: | 55 | | OK |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!
dataInterpolateBicubic (Begins at: 431 Ends at: 482)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 9 | *** | MONSTER |
CalledNBR: | 19 | | OK |
LOC: | 52 | | OK |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!
obsEstimateBilin (Begins at: 488 Ends at: 527)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 10 | *** | MONSTER |
CalledNBR: | 7 | | OK |
LOC: | 40 | | OK |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!
dataInterpolateBilin (Begins at: 533 Ends at: 569)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 9 | *** | MONSTER |
CalledNBR: | 7 | | OK |
LOC: | 37 | | OK |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!
Clone analysis:
This file has 2 potentially cloned functions:
node_y node_x
In vector/lidar/lidarlib/InterpSpline.c clones of node_x are:
vector/lidar/lidarlib/InterpSpline.c node_y
In vector/lidar/lidarlib/InterpSpline.c clones of node_y are:
vector/lidar/lidarlib/InterpSpline.c node_x
__________________________________________
Threshold GRASS6 key metrics values at 2006-08-22 are:
---------------------------+-----------+---------+
median | upper | outlier |
| quartile | limit |
---------------------------+-----------+---------+
Complexity (Cyclo): 5 | 25 | 36 |
ParamNBR: 2 | 6 | 8 |
CalledNBR: 9 | 55 | 80 |
LOC: 39 | 179 | 251 |
---------------------------+-----------+---------+
Measures (see below Web page for details):
Complexity (Cyclo): a complexity index
ParamNBR: number of passed parameters
CalledNBR: number of called functions
LOC: Lines Of Code
Message interpretation:
OK : Nothing to say at all
* : above 75 % of value warning
** : this is getting close to be out of range, consider revising the code
***: this is a monster, definitely you should revise this function
__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html
More information about the grass-qa
mailing list